Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticArgumentRenameBase and DrupalServiceRenameBase are now covered with StaticArgumentRenameRector #241

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

bbrala
Copy link
Collaborator

@bbrala bbrala commented Aug 21, 2023

Description

Migrate to a configured rule for StaticArgumentRenameRector and all child classes.

Drupal.org issue

Provide a link to the issue from https://www.drupal.org/project/rector/issues. If no issue exists, please create one and link to this PR.

Copy link
Collaborator

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be more pointed at service name replacement

@bbrala bbrala force-pushed the feature/static-argument-rename-rector branch from 60ef2a6 to 0ac14fa Compare August 22, 2023 10:10
@bbrala bbrala requested a review from mglaman August 22, 2023 12:05
@bbrala bbrala merged commit c8e5d87 into main Aug 22, 2023
12 checks passed
@bbrala bbrala deleted the feature/static-argument-rename-rector branch September 4, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants