-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor fixed #26
Some minor fixed #26
Conversation
Hi, I am trying this and the changes are really minor issues, So I don't understand why some test fail. Maybe the C-g change in the test needs a similar change than in the code? Because C-g was not working before. in Travis it says for the failing test:
But manually this scenario works for me. Please could you give a look and accept when fixed? |
Changed mark-active check for mark-active-p. Also the mark is properly deactivated when exiting the composable-object-mode.
kbd macros where not executed, so, the combinations C-g was unset.
This change enables to track the number of times a command was repeater.
@paldepind |
He @Ergus. Thank you for the PR. I have exams at the moment but I'll take a look as soon as I get the time. |
This fixes the need of repeating commands without undoing the previous one. It is more efficient for copies and fixes issue paldepind#22.
Hi I added some more changes to fix the issue #22 (because I faced it). It seems to be working, in spite of Travis shows errors in the tests, but when I try the actions manually they produce the expected output. Could you please check this when you have some time? |
Looks super great @Ergus. Thanks a lot. The fixes are nice and the which-key integration is really useful. Thank again 👍 |
mark-even-if-inactive
isnil
.