Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgPersistence strict mode error #35

Closed
awitherow opened this issue Sep 29, 2016 · 3 comments · Fixed by #36
Closed

pgPersistence strict mode error #35

awitherow opened this issue Sep 29, 2016 · 3 comments · Fixed by #36

Comments

@awitherow
Copy link

awitherow commented Sep 29, 2016

First of all, really thank you @paldepind ! This is a great first step in my app going offline-first.

I am currently implementing synceddb in a PR on my own personal app and my server continues to crash with the following error:

.../aether/node_modules/synceddb-persistence-postgres/index.js:11
let nextKey;
^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

The pull request that I am developing on can be found here:

awitherow/aethernote#36

questions...

  1. Am I doing something wrong?
  2. Is it okay to not use the server with the rest of the code I'm using on the client side?
@piglovesyou
Copy link
Collaborator

piglovesyou commented Sep 30, 2016

  1. No, only I didn't write "use strict"; on top of the files (you might use v4?). I'm glad if you give me a PR.
  2. OK without syncing

piglovesyou added a commit that referenced this issue Oct 7, 2016
piglovesyou added a commit that referenced this issue Oct 8, 2016
From next time `publish_all.sh` will publish all persistence modules
with the same version.
pros: I will never forget publish modified module.
cons: library users will recieve update even when it's not modified.
@piglovesyou piglovesyou mentioned this issue Oct 8, 2016
piglovesyou added a commit that referenced this issue Oct 8, 2016
piglovesyou added a commit that referenced this issue Oct 8, 2016
From next time `publish_all.sh` will publish all persistence modules
with the same version.
pros: I will never forget publish modified module.
cons: library users will recieve update even when it's not modified.
@piglovesyou
Copy link
Collaborator

@awitherow Please try newer module, it should work.

@paldepind
Copy link
Owner

First of all, really thank you @paldepind ! This is a great first step in my app going offline-first.

You should thank @piglovesyou as well 😄 He has done a lot of great work on this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants