-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use geoarrow-c for input functionality #16
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 32.71% 28.04% -4.67%
==========================================
Files 14 16 +2
Lines 1458 1747 +289
Branches 28 35 +7
==========================================
+ Hits 477 490 +13
- Misses 973 1249 +276
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Small question: the title of the PR mentions "input/output", but is my reading correct that at the moment this PR only adds the "input" part? (there only seems to be a reader that goes from any sort of ArrowArray to a vector of Geography objects) |
I need to revisit this PR! I think the output part is actually much easier than the input part, and that the goal of this PR is to remove the shim I had added earlier that was a previous (and untested) version of a C++ geoarrow library. In order to remove that shim, I think it would have to handle both. |
fee28ca
to
bf1e79c
Compare
Small point of feedback, regarding the code structure: IMO it would be clearer if you put the geoarrow code in e.g. a |
I still think this is true, but I'll merge this to hopefully unblock some of the things you are working on. For both input and output it may be worth avoiding geoarrow-c here, but at least this gets to a place where we can write tests and then improve the implementation. (All of this is code I wrote a long time ago!) |
No description provided.