New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #22 (WIP!) #32
Fixes #22 (WIP!) #32
Conversation
I'm not familiar with Django, but |
@@ -1,4 +1,4 @@ | |||
FROM python:3 | |||
WORKDIR /work | |||
COPY requirements.txt /work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not even sure if this is the right solution at all, but if there is a "COPY ." at all, it shouldn't occur until after the pip install as this way around means it'll reinstall everything every time anyone makes any source changes as opposed to only when the dependencies change.
@@ -0,0 +1 @@ | |||
python manage.py migrate && python manage.py runserver "0.0.0.0:$PORT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What runs this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, shouldn't have commited that.
@@ -1,2 +1,2 @@ | |||
web: python manage.py migrate && python manage.py runserver "0.0.0.0:$PORT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "||" will result in if the "migrate" returns 0 the "runserver" won't happen at all.
Obsoleted by #34 |
I fixed the Missing Procfile problem from #22 by copying it to the
WORKDIR
. Then, upon deploy, dokku couldn't findmanage,py
, so I copied everything to theWORKDIR
. Problem is dokku seems to be passingpython manage.py runserver 0.0.0.0:$PORT
tomanage.py
as arguments, instead of running it as a separate command.