Add retrieving list of versions support #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
requested changes
May 18, 2023
lib/logidze/model.rb
Outdated
| versions_meta = reverse ? log_data.versions.reverse : log_data.versions | ||
| versions_meta = versions_meta.reject { _1.version == log_data.version } unless include_self | ||
|
|
||
| versions_meta.map { at(version: _1.version) }.to_enum |
There was a problem hiding this comment.
We wanted this method to return an enumerator to avoid expensive calculation and object creation of generating all versions, i.e., when I call record.logidze_versions.take(2) I only call #at twice. Right how, we create an array of all version first—this is not optimal.
We can add a test to check that we don't create a record per version by adding an after_initialize callback and increment some counter within it.
|
Is it ok, @palkan? |
palkan
approved these changes
Jun 8, 2023
|
LGTM 👍 Let's add a changelog entry and update the docs. |
|
Thanks! |
miharekar
added a commit
to miharekar/logidze
that referenced
this pull request
Mar 2, 2024
It was implemented as such in palkan#238
3 tasks
palkan
pushed a commit
that referenced
this pull request
Mar 5, 2024
It was implemented as such in #238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add retrieving list of versions support
What changes did you make? (overview)
Added
#logidze_versionsmethod which retrieves list of versions of model depending on options provided (reverseandinclude_selfIf
reverseis provided, reversed Enumerator will be returned.If
include_selfis provided, the list will contain also current version of the model.Is there anything you'd like reviewers to focus on?
Checklist