Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace #versions with #logidze_versions in README #245

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

miharekar
Copy link
Contributor

@miharekar miharekar commented Mar 2, 2024

Saw this today, and wanted to use it, and learned that README is all wrong 😅

It was implemented as #logidze_versions in #238.

And here are the results:

irb(main):043> cafe.logidze_versions.map{|v| v.log_version}
=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]
irb(main):044> cafe.logidze_versions(reverse: true).map{|v| v.log_version}
=> [12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1]
irb(main):045> cafe.logidze_versions(include_self: true).map{|v| v.log_version}
=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13]
irb(main):046> cafe.logidze_versions(reverse: true, include_self: true).map{|v| v.log_version}
=> [13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1]

So most of the readme of this method is currently wrong 🙈

What is the purpose of this pull request?

Fix README and CHANGELOG to be correct.

What changes did you make? (overview)

Is there anything you'd like reviewers to focus on?

Checklist

  • I've added tests for this change
  • I've added a Changelog entry
  • I've updated a documentation (Readme)

@palkan
Copy link
Owner

palkan commented Mar 5, 2024

Oops :( Thanks for fixing this!

@palkan palkan merged commit cc0028a into palkan:master Mar 5, 2024
13 checks passed
@miharekar miharekar deleted the fix-readme branch April 25, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants