Inspect reloaded object should maintain changes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Thanks!
calling inspect causes the issue and would love to find out!
#inspect calls #attribute_for_inspect:
https://github.com/rails/rails/blob/6d3aedbbf27b89d0170a2ee024e7845c157e5697/activerecord/lib/active_record/attribute_methods.rb#L283-L288
Which calls _read_attribute and populate the defaults (making the original changes dirty).
|
Released in 0.9.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Documents and fixes an issue found while using the gem. I can't quite understand what part of re-initializing and calling inspect causes the issue and would love to find out!
What changes did you make? (overview)
Clear the changes hash for an accessor if there are no changes to the attributes
Is there anything you'd like reviewers to focus on?
Why the hell does this happen? :D
Checklist