Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Ignite backend support #254

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sdarlington
Copy link

Currently, draft as it needs the development/next version of the Python thin-client. But comments welcomed.

Copy link
Collaborator

@sh4nks sh4nks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left a few comments on your draft if you want to have it included in Flask-Caching.

@@ -25,6 +25,7 @@
)
from flask_caching.backends.simplecache import SimpleCache
from flask_caching.backends.uwsgicache import UWSGICache
from flask_caching.contrib.ignitecache import IgniteCache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include your backend here. This is only for officially supported backends and not for user contributed backends.

@@ -0,0 +1,3 @@
from .ignitecache import IgniteCache

__all__ = ['IgniteCache']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to only use the full important path for contributed caches -- without importing the cache class here.

@@ -11,6 +11,7 @@
SASLMemcachedCache,
SimpleCache,
SpreadSASLMemcachedCache,
IgniteCache,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't provide tests in the official testsuite for use contributed backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants