Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Flask-Mail #531

Closed
sr-verde opened this issue Oct 5, 2021 · 3 comments · Fixed by #598
Closed

Get rid of Flask-Mail #531

sr-verde opened this issue Oct 5, 2021 · 3 comments · Fixed by #598
Assignees
@jwag956
Labels
chore CI/CD; update packages, fix deprecation warnings, ...
Milestone
5.0.0

Comments

@sr-verde
Copy link
Contributor

sr-verde commented Oct 5, 2021

Flask-Mail is unmaintained since 2014 (as you know, I think 😉). Since there are security related issues, I want to suggest to get rid of this dependency. @waynerv has ported Django's email implementation to a Flask extension. So this may be an alternative.

What do you think? I know, this would be a major change. But actually, Flask-Security contains a lot of unmaintained dependencies (Flask-Mail, Flask-Principal, pyqrcode) and I think it would be a chance to improve this project.

Best Pascua
@jwag956
Copy link
Collaborator

jwag956 commented Oct 5, 2021

Thanks for the idea and the pointer to a newer mail package.
This should be pretty easy since as of 4.0.0 flask_mail hasn't been required and is encapsulated in the MailUtil class.

I'll look into doing something like I did for flask-babelex versus flask-babel - import one or the other...

@jwag956 jwag956 added this to the 4.2.0 milestone Apr 3, 2022
@jwag956 jwag956 self-assigned this Apr 3, 2022
@jwag956 jwag956 added chore CI/CD; update packages, fix deprecation warnings, ... and removed enhancement labels Apr 3, 2022
jwag956 added a commit that referenced this issue Apr 4, 2022
@jwag956
Convert to using flask-mailman as default outbound mail handler.
bbab879 
flask-mail has been abandoned - flask-mailman is a newer package that provides similar functionality to Django mail.

Use flask-mailmanas our default and in all the examples. flask-mail is still supported - and of course from a runtime perspective this all can be easily overwritten using the MailUtil class.

Most changes were around flask-mailman having a different way of capturing outbound emails during testing.

Closes: #531
@jwag956 jwag956 mentioned this issue Apr 4, 2022
Merged
jwag956 added a commit that referenced this issue Apr 4, 2022
@jwag956
Convert to using flask-mailman as default outbound mail handler.
b19d71f 
flask-mail has been abandoned - flask-mailman is a newer package that provides similar functionality to Django mail.

Use flask-mailmanas our default and in all the examples. flask-mail is still supported - and of course from a runtime perspective this all can be easily overwritten using the MailUtil class.

Most changes were around flask-mailman having a different way of capturing outbound emails during testing.

Closes: #531
jwag956 added a commit that referenced this issue Apr 4, 2022
@jwag956
Convert to using flask-mailman as default outbound mail handler. (#598)
08d6504 
flask-mail has been abandoned - flask-mailman is a newer package that provides similar functionality to Django mail.

Use flask-mailmanas our default and in all the examples. flask-mail is still supported - and of course from a runtime perspective this all can be easily overwritten using the MailUtil class.

Most changes were around flask-mailman having a different way of capturing outbound emails during testing.

Closes: #531
@sr-verde
Copy link
Contributor Author

FYI: There is a new Flask-Mail version. 😮

https://github.com/pallets-eco/flask-mail/releases/tag/0.10.0

@jwag956
Copy link
Collaborator

jwag956 commented May 24, 2024

Yea - saw that - not a big deal to support it again.... As an aside - I am in the process of working with pallets to move flask-security under their repo and become the 'one' flask-security (including pypi).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jwag956 jwag956

Labels
chore CI/CD; update packages, fix deprecation warnings, ...
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Convert to using flask-mailman as default outbound mail handler. pallets-eco/flask-security
2 participants
@jwag956 @sr-verde