Autodelete sessions in SqlAlchemySessionInterface #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expired sessions are not deleted from the database in every case, so the autodeletion of expired sessions has been implemented. Deletion of the expired sessions (e.g. with a cronjob) would be feasible in the application, but it is nicer to implement it directly in flask-session. The autodeletion be enabled by the `SESSION_AUTODELETE` config variable, which defaults to `False`. Major drawback: it slows down `open_session`.
steinsag
reviewed
Jan 15, 2021
| @@ -561,3 +568,13 @@ def save_session(self, app, session, response): | |||
| response.set_cookie(app.session_cookie_name, session_id, | |||
| expires=expires, httponly=httponly, | |||
| domain=domain, path=path, secure=secure) | |||
|
|
|||
| def delete_expired_sessions(self): | |||
| expired_sessions = self.sql_session_model.query.filter( | |||
There was a problem hiding this comment.
I think you can simplify that to something like:
self.sql_session_model.query.filter(self.sql_session_model.expiry < datetime.utcnow()).delete()
self.db.session.commit()
|
hi, |
christopherpickering
added a commit
to christopherpickering/flask-session2
that referenced
this pull request
Aug 17, 2022
This was referenced May 11, 2023
Closed
|
Both these features is now included in 0.7.0 PR #212 as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expired sessions are not deleted from the database in every case, so
the autodeletion of expired sessions has been implemented.
Deletion of the expired sessions (e.g. with a cronjob) would be feasible
in the application, but it is nicer to implement it directly in
flask-session.
The autodeletion be enabled by the
SESSION_AUTODELETEconfig variable,which defaults to
False.Major drawback: it slows down
open_session.