Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional current_item parameter to ProgressBar.update() #1332

merged 1 commit into from Aug 1, 2019


Copy link

@thecav thecav commented May 31, 2019

Fix #1226 Add an optional current_item parameter to ProgressBar.update() to allow for item_show_func to continue to display when using update(). A usage example for this was added to ProgressBar and some new tests.

Copy link

jcrotts commented May 31, 2019

Could you add an entry to the changelog, and a version added marker to the new docs you added. Thanks for the PR.

Copy link
Contributor Author

thecav commented Jun 2, 2019

Sure, would this go under the unreleased 7.1 section?

Copy link

jcrotts commented Jun 2, 2019

David may say otherwise but since this is a new feature it will probably go under 8.0 unreleased. 7.1 is for bugs and docs changes.

This allows updating what item is displayed when using
ProgressBar.update to control the exact progress.
@davidism davidism merged commit 716a5be into pallets:master Aug 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

Add current_item parameter to ProgressBar.update()
3 participants