Skip to content

Add an optional current_item parameter to ProgressBar.update() #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

thecav
Copy link
Contributor

@thecav thecav commented May 31, 2019

Fix #1226 Add an optional current_item parameter to ProgressBar.update() to allow for item_show_func to continue to display when using update(). A usage example for this was added to ProgressBar and some new tests.

@jcrotts
Copy link
Contributor

jcrotts commented May 31, 2019

Could you add an entry to the changelog, and a version added marker to the new docs you added. Thanks for the PR.

@thecav
Copy link
Contributor Author

thecav commented Jun 2, 2019

Sure, would this go under the unreleased 7.1 section?

@jcrotts
Copy link
Contributor

jcrotts commented Jun 2, 2019

David may say otherwise but since this is a new feature it will probably go under 8.0 unreleased. 7.1 is for bugs and docs changes.

@thecav thecav force-pushed the update-current-item branch from b38a826 to 61b40f5 Compare June 3, 2019 14:05
@davidism davidism added this to the 8.0 milestone Jun 3, 2019
@thecav thecav force-pushed the update-current-item branch from 61b40f5 to 7592de8 Compare June 5, 2019 13:22
@davidism davidism force-pushed the update-current-item branch from 7592de8 to cdd0080 Compare August 1, 2019 20:00
This allows updating what item is displayed when using
ProgressBar.update to control the exact progress.
@davidism davidism force-pushed the update-current-item branch from cdd0080 to 04a17ae Compare August 1, 2019 20:07
@davidism davidism merged commit 716a5be into pallets:master Aug 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add current_item parameter to ProgressBar.update()
3 participants