Add an optional current_item parameter to ProgressBar.update() #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add an entry to the changelog, and a version added marker to the new docs you added. Thanks for the PR. |
|
Sure, would this go under the unreleased 7.1 section? |
|
David may say otherwise but since this is a new feature it will probably go under 8.0 unreleased. 7.1 is for bugs and docs changes. |
thecav
force-pushed
the
update-current-item
branch
from
b38a826
to
61b40f5
Compare
thecav
force-pushed
the
update-current-item
branch
from
61b40f5
to
7592de8
Compare
davidism
force-pushed
the
update-current-item
branch
from
7592de8
to
cdd0080
Compare
This allows updating what item is displayed when using ProgressBar.update to control the exact progress.
davidism
force-pushed
the
update-current-item
branch
from
cdd0080
to
04a17ae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1226 Add an optional
current_itemparameter toProgressBar.update()to allow foritem_show_functo continue to display when usingupdate(). A usage example for this was added toProgressBarand some new tests.