Skip to content

Commit

Permalink
Merge pull request #4544 from bebleo/mark_run_cert_option_eager
Browse files Browse the repository at this point in the history
  • Loading branch information
davidism committed Apr 24, 2022
2 parents dba2be9 + 5050a18 commit 2ec1193
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.rst
Expand Up @@ -7,6 +7,8 @@ Unreleased

- Fix type annotation for ``json.loads``, it accepts str or bytes.
:issue:`4519`
- The ``--cert`` and ``--key`` options on ``flask run`` can be given
in either order. :issue:`4459`


Version 2.1.1
Expand Down
5 changes: 4 additions & 1 deletion src/flask/cli.py
Expand Up @@ -763,7 +763,10 @@ def convert(self, value, param, ctx):
@click.option("--host", "-h", default="127.0.0.1", help="The interface to bind to.")
@click.option("--port", "-p", default=5000, help="The port to bind to.")
@click.option(
"--cert", type=CertParamType(), help="Specify a certificate file to use HTTPS."
"--cert",
type=CertParamType(),
help="Specify a certificate file to use HTTPS.",
is_eager=True,
)
@click.option(
"--key",
Expand Down
5 changes: 5 additions & 0 deletions tests/test_cli.py
Expand Up @@ -553,9 +553,14 @@ def test_run_cert_path():
with pytest.raises(click.BadParameter):
run_command.make_context("run", ["--key", __file__])

# cert specified first
ctx = run_command.make_context("run", ["--cert", __file__, "--key", __file__])
assert ctx.params["cert"] == (__file__, __file__)

# key specified first
ctx = run_command.make_context("run", ["--key", __file__, "--cert", __file__])
assert ctx.params["cert"] == (__file__, __file__)


def test_run_cert_adhoc(monkeypatch):
monkeypatch.setitem(sys.modules, "cryptography", None)
Expand Down

0 comments on commit 2ec1193

Please sign in to comment.