load_dotenv returns true even if no file exists

[lec00q]

Expected Behavior

If no file is loaded/exists, flask.cli.load_dotenv should return False.

Actual Behavior

This code:

from flask import Flask
from flask.cli import load_dotenv

app = Flask(__name__)
result = load_dotenv('not-exist')
assert result

does not fail.

Environment

• Python version: 3.5.5
• Flask version: 1.0.2
• Werkzeug version: 0.14.1

[greyli]

IMO, it's a default behavior of python-dotenv:

>>> from dotenv import load_dotenv
>>> load_dotenv('nothing')
>>> True

Source

[jacquerie]

it's a default behavior of python-dotenv:

That's true, but the docstring promises a different thing:

flask/flask/cli.py

Line 587 in d7eea1b

:return: ``True`` if a file was loaded.

[lec00q]

I was in fact referring to that promise. As a side note, I think that it also make sense, but this is just a personal opinion.

[greyli]

Maybe we can change this line to something like "True if a file was loaded or path is not None."?