-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Flask-Sijax for approval. #317
Comments
Listed. Recommendation: move the init_app and route functions into methods of the SijaxHelper class, and consider shortening the name for SijaxHelper to just Sijax. These changes would lead to an API that is more consistent with Flask extension patterns. I'm testing with Flask 0.8, and test_sijax_helper_object_is_only_bound_to_g_in_a_request_context errors out with Python 2.5 breaks, starting with lack of JSON support (json was added in Python 2.6, based on simplejson package). |
Thanks for the suggestions. The test was broken, because of a change in Flask 0.7 - this is now fixed. I renamed the class from SijaxHelper to Sijax and changed things a bit, so it implements the init_app pattern seen in other extensions (the I kept the route helper decorator at the module level (currently What do you suggest should be done about Python 2.5 and JSON? The Sijax library throws a |
You can add simplejson as requirement to sijax only when needed - in Python < 2.6. |
Fixed. Thanks @alekzvik |
You're welcome. |
Because the extension seems small enough (~200 lines) and splitting it into modules didn't seem justified. If you're asking why I didn't package a single module file (flask_sijax.py), instead of a "one file package", I guess that would be possible now. It had to be a package at the time Flask encouraged namespaced packages for extensions. |
please refile against https://github.com/pocoo/metaflask |
Slavi Pantaleev
http://packages.python.org/Flask-Sijax/
The text was updated successfully, but these errors were encountered: