Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate flask.ext #1484

Merged
merged 4 commits into from Apr 2, 2016

Conversation

@untitaker
Copy link
Member

commented Jun 6, 2015

See #1135

@untitaker

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2015

cc @DasIch (now on the PR properly)

@untitaker untitaker added this to the 1.0 milestone Jun 14, 2015

@ThiefMaster

This comment has been minimized.

Copy link
Member

commented Jun 19, 2015

Would it make sense to show a different warning in case a flask.ext import points to an old flaskext package?

@untitaker

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2015

@ThiefMaster fixed, an additional warning is now shown. One is addressing the app dev, the other the extension dev.

@prologic prologic referenced this pull request Aug 11, 2015
@davidism

This comment has been minimized.

Copy link
Member

commented Oct 31, 2015

What are we waiting on to merge this?

@untitaker

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2015

Feel free to do so.

On 31 October 2015 05:02:17 CET, David Lord notifications@github.com wrote:

What are we waiting on to merge this?


Reply to this email directly or view it on GitHub:
#1484 (comment)

Sent from my phone. Please excuse my brevity.

@jeffwidman

This comment has been minimized.

Copy link
Member

commented Dec 30, 2015

Can someone rebase and then merge this?

Seems like this is all that's needed to check one of the #1182 checkboxes.

@untitaker untitaker force-pushed the untitaker:ext-deprecation-new branch from 7f30cdb to 7ede661 Apr 2, 2016

@untitaker untitaker assigned untitaker and mitsuhiko and unassigned untitaker Apr 2, 2016

@mitsuhiko

This comment has been minimized.

Copy link
Member

commented Apr 2, 2016

Let's merge this.

@untitaker untitaker merged commit d3d8a46 into pallets:master Apr 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@untitaker untitaker deleted the untitaker:ext-deprecation-new branch Apr 2, 2016

untitaker added a commit that referenced this pull request Apr 2, 2016

@untitaker untitaker removed the needs review label Apr 2, 2016

@methane methane referenced this pull request Apr 4, 2016
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.