Error handler support for generic HttpException #2082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed (any kind of error)
cerickson
added a commit
to cerickson/flask
that referenced
this pull request
May 22, 2017
Error handlers are now returned in order of blueprint:code, app:code, blueprint:HTTPException, app:HTTPException, None Corresponding tests also added. Ref issue pallets#941, pr pallets#1383, pallets#2082, pallets#2144
|
Thanks for this. Closing in favor of #2304 which is a more extensive solution to this. |
cerickson
added a commit
to cerickson/flask
that referenced
this pull request
May 23, 2017
Error handlers are now returned in order of blueprint:code, app:code, blueprint:HTTPException, app:HTTPException, None Corresponding tests also added. Ref issue pallets#941, pr pallets#1383, pallets#2082, pallets#2144
cerickson
added a commit
to cerickson/flask
that referenced
this pull request
May 23, 2017
Error handlers are now returned in order of blueprint:code, app:code, blueprint:HTTPException, app:HTTPException, None Corresponding tests also added. Ref issue pallets#941, pr pallets#1383, pallets#2082, pallets#2144
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flask supports setting HttpException as error handler class:
This fills
error_handler_specwith something like this for any blueprint{None: {None: lambda_function}}However, when finding the error handler it checks the error code which is e.g. 404 and ignores None, the error handler for any error, previously set by register_error_handler. It doesn't find 404, doesn't check for None in the dict and falls back to the default error handler which shouldn't happen.