Skip to content

Fixes issue #2824 flask --version - #2825

Merged
davidism merged 2 commits into
pallets:1.0-maintenancefrom
eso31:fix-2824-issue
Jan 7, 2019
Merged

Fixes issue #2824 flask --version#2825
davidism merged 2 commits into
pallets:1.0-maintenancefrom
eso31:fix-2824-issue

Conversation

@eso31

@eso31 eso31 commented Jun 11, 2018

Copy link
Copy Markdown
Contributor

Fixes issue 2824

Now when you run flask --version command it shows you the Werkzeug version as well. I changed the order as well to be Python, Flask and Werkzeug as it is shown in the issue template.

Let me know if it has to be done in some other way.

@emil45

emil45 commented Jun 16, 2018

Copy link
Copy Markdown

It is best to remain consistent, the version of Flask imported in the global scope (line 28).
So werkzeug version should be also be imported in the global scope, rather than within the function.

As for the idea itself, I responded to you in issue.

Comment thread flask/cli.py Outdated
Comment thread flask/cli.py Outdated
@pallets pallets locked as off-topic and limited conversation to collaborators Jul 24, 2018
@davidism
davidism changed the base branch from master to 1.0-maintenance January 7, 2019 00:17
@davidism davidism added the cli label Jan 7, 2019
@davidism davidism added this to the 1.0.3 milestone Jan 7, 2019
@davidism
davidism merged commit 232e5c8 into pallets:1.0-maintenance Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants