Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes issue #2824 flask --version #2825
Conversation
This comment has been minimized.
This comment has been minimized.
emil45
commented
Jun 16, 2018
|
It is best to remain consistent, the version of As for the idea itself, I responded to you in issue. |
davidism
referenced this pull request
Jul 12, 2018
Closed
fix #2824 output more versions related flask #2862
| @@ -21,6 +21,7 @@ | ||
| from functools import update_wrapper | ||
| from operator import attrgetter | ||
| from threading import Lock, Thread | ||
| from werkzeug import __version__ as werkzeug_version |
This comment has been minimized.
This comment has been minimized.
cdvv7788
Jul 17, 2018
What about importing werkzeug and referencing the version with werkzeug.__version__?
It is clear enough, and it is not as if it is being used anywhere else.
| @@ -259,10 +260,11 @@ def locate_app(script_info, module_name, app_name, raise_if_not_found=True): | ||
| def get_version(ctx, param, value): | ||
| if not value or ctx.resilient_parsing: | ||
| return | ||
| message = 'Flask %(version)s\nPython %(python_version)s' | ||
| message = 'Python %(python_version)s\nFlask %(version)s\nWerkzeug %(werkzeug_version)s' |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
xavierhardy
Jul 23, 2018
Given the fact that it was originally there, I don't think so; it's not the point of this pull request. By the way, % is faster and more retro-compatible than .format.
https://hackernoon.com/a-closer-look-at-how-python-f-strings-work-f197736b3bdb
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
xavierhardy
Jul 23, 2018
Sure, then make a separate pull request, since most of this code uses % over .format.
~/src/flask$ find ./ -name "*.py" -exec grep -H "%" {} \; | wc -l
90
~/src/flask$ find ./ -name "*.py" -exec grep -H "\.format" {} \; | wc -l
37But again, this is not the point of this pull request.
eso31 commentedJun 11, 2018
Fixes issue 2824
Now when you run
flask --versioncommand it shows you the Werkzeug version as well. I changed the order as well to be Python, Flask and Werkzeug as it is shown in the issue template.Let me know if it has to be done in some other way.