Skip to content

/ flask

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #2824 flask --version #2825

Merged
merged 2 commits into from Jan 7, 2019
Merged

Fixes issue #2824 flask --version #2825

merged 2 commits into from Jan 7, 2019

Conversation

@eso31
Copy link
Contributor

@eso31 eso31 commented Jun 11, 2018

Fixes issue 2824

Now when you run flask --version command it shows you the Werkzeug version as well. I changed the order as well to be Python, Flask and Werkzeug as it is shown in the issue template.

Let me know if it has to be done in some other way.
@emil45
Copy link

@emil45 emil45 commented Jun 16, 2018

It is best to remain consistent, the version of Flask imported in the global scope (line 28).
So werkzeug version should be also be imported in the global scope, rather than within the function.

As for the idea itself, I responded to you in issue.
@davidism davidism mentioned this pull request Jul 12, 2018
Closed
@cdvv7788
cdvv7788 reviewed Jul 17, 2018
View changes
flask/cli.py Outdated Show resolved Hide resolved
flask/cli.py Outdated Show resolved Hide resolved
@pallets pallets locked as off topic and limited conversation to collaborators Jul 24, 2018
@eso31 @davidism
add werkzeug to flask --version
Verified
This commit was signed with a verified signature.
davidism David Lord
GPG key ID: 7A1C87E3F5BC42A8 Learn about signing commits
3fd51c6
@davidism davidism force-pushed the eso31:fix-2824-issue branch from b549257 to 679fa78 Jan 7, 2019
@davidism davidism changed the base branch from master to 1.0-maintenance Jan 7, 2019
@davidism davidism added the cli label Jan 7, 2019
@davidism davidism added this to the 1.0.3 milestone Jan 7, 2019
@davidism davidism force-pushed the eso31:fix-2824-issue branch from 679fa78 to 538206d Jan 7, 2019
@davidism
clean up flask --version code
Verified
This commit was signed with a verified signature.
davidism David Lord
GPG key ID: 7A1C87E3F5BC42A8 Learn about signing commits
Loading status checks…
a0ccc47
@davidism davidism force-pushed the eso31:fix-2824-issue branch from 538206d to a0ccc47 Jan 7, 2019
@davidism davidism merged commit 232e5c8 into pallets:1.0-maintenance Jan 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavierhardy xavierhardy

@cdvv7788 cdvv7788

Assignees
No one assigned
Labels
cli
Milestone
1.0.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@eso31 @emil45 @xavierhardy @cdvv7788 @davidism