fix for https://github.com/mitsuhiko/flask/issues/494 #497

Merged
merged 2 commits into from Jun 17, 2012

Conversation

Projects
None yet
3 participants
Contributor

ekoka commented Apr 22, 2012

Flask.inject_url_defaults() incorrectly splits endpoint's to get blueprint's name.

replaced call to endpoint.split() by endpoint.rsplit() on line 1471 of flask/app.py

Contributor

rduplain commented Apr 22, 2012

Thanks for the pull request to fix #494. Could you add a test case to catch the error, which passes with this fix?

Contributor

ekoka commented Apr 23, 2012

Sure, I have one. Do you have a specific convention? i.e. where should I put it? what should I name id?

Contributor

ekoka commented Apr 24, 2012

not exactly sure if this is where the test should go, but there it is.

mitsuhiko merged commit a9e753f into pallets:master Jun 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment