Merge pull request #938 from stevenorum/master

Fixing compiler handling of parens around boolean comparisons.
pallets · Oct 7, 2019 · f1d199a · f1d199a
2 parents c8b1b02 + eca6fbf
commit f1d199a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/jinja2/compiler.py b/jinja2/compiler.py
@@ -1529,9 +1529,11 @@ def visit_Concat(self, node, frame):
 
     @optimizeconst
     def visit_Compare(self, node, frame):
+        self.write('(')
         self.visit(node.expr, frame)
         for op in node.ops:
             self.visit(op, frame)
+        self.write(')')
 
     def visit_Operand(self, node, frame):
         self.write(' %s ' % operators[node.op])

diff --git a/tests/test_lexnparse.py b/tests/test_lexnparse.py
@@ -332,6 +332,12 @@ def test_compare(self, env):
                                '{{ 2 == 2 }}|{{ 1 <= 1 }}')
         assert tmpl.render() == 'True|True|True|True|True'
 
+    def test_compare_parens(self, env):
+        tmpl = env.from_string(
+            "{{ i*(j<5) }}"
+        )
+        assert tmpl.render(i=2, j=3) == '2'
+
     def test_inop(self, env):
         tmpl = env.from_string('{{ 1 in [1, 2, 3] }}|{{ 1 not in [1, 2, 3] }}')
         assert tmpl.render() == 'True|False'