Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated class FunctionLoader(BaseLoader) method: get_source to be con… #630

Closed
wants to merge 0 commits into from

Conversation

drewja
Copy link
Contributor

@drewja drewja commented Dec 17, 2016

…sistant with the rest of the api. A FunctionLoader instance is initalized with a callback (load_func) which can optionaly return a string, In this case this method was missing autoreload behavior that is common to the other get_source methods.

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase and add some tests and release note

@mitsuhiko
Copy link
Contributor

Pulling this if you add a test for it and remove the changes to setup.cfg.

@drewja drewja closed this Jan 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants