Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClosingIterator closes iterable passed to it and not the iterator #1260

Merged
merged 2 commits into from May 30, 2018
Merged

ClosingIterator closes iterable passed to it and not the iterator #1260

merged 2 commits into from May 30, 2018

Commits on May 29, 2018

  1. ClosingIterator closes iterable passed to it. 

    This is a fix for pallets#1259.

According to [wsgi specification](https://www.python.org/dev/peps/pep-3333):

> If the iterable returned by the application has a close() method, the
> server or gateway must call that method upon completion of the current
> request

This commit adds test for this and fixes the issue.
    @romank0 @davidism
    romank0 authored and davidism committed May 29, 2018
    Copy the full SHA
    977ba0e View commit details
    Browse the repository at this point in the history

Commits on May 30, 2018

  1. refactor test, add changelog

    @davidism
    davidism committed May 30, 2018
    Copy the full SHA
    f048c0b View commit details
    Browse the repository at this point in the history