[RFC] reloader: wait for finished request #1525
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server should not be restarted while debugging (
pdb.set_trace()
).Use case:
pdb.set_trace
in the codeedit
(via pdbpp) to edit filesThis ends up in garbarge on the screen, and the server process/thread getting killed.
With this patch it waits for wsgi requests to finish before reloading.
Not much tested yet, and could certainly need a revisit/cleanup.