Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] reloader: wait for finished request #1525

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@blueyed
Copy link

commented Apr 28, 2019

The server should not be restarted while debugging (pdb.set_trace()).

Use case:

  1. pdb.set_trace in the code
  2. trigger web request
  3. start debugging / messing around, maybe even use edit (via pdbpp) to edit files
  4. save something being watched

This ends up in garbarge on the screen, and the server process/thread getting killed.

With this patch it waits for wsgi requests to finish before reloading.

Not much tested yet, and could certainly need a revisit/cleanup.

blueyed added some commits Apr 28, 2019

reloader: wait for finished request
The server should not be restarted while debugging (`pdb.set_trace()`).

@blueyed blueyed force-pushed the blueyed:wait-for-reload branch from 1c4b2af to 604b9e1 May 8, 2019

@davidism

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

I'm hesitant to make these sorts of changes to the reload right now, as it's already a fairly complex system that I'm not having the easiest time maintaining. I'm worried about other behaviors as well, such as the reloader never triggering due to a large file upload/download, or a long running request. I'd say the much simpler answer for now is to disable the reloader if it's getting you during debugging.

@davidism davidism closed this Jul 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.