enable conditional and disable max_age by default #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
send_file-conditional
branch
from
42664a1
to
9006627
Compare
Let browsers validate conditions rather than using a 12 hour timed cache by default. Send Cache-Control: no-cache by default, or public if max_age > 0. Rename cache_timeout to max_age. Make environ parameter required.
davidism
force-pushed
the
send_file-conditional
branch
from
9006627
to
e91b36d
Compare
This was referenced Nov 4, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tells browsers to validate cache conditions (etag, last modified, range) rather than using a 12 hour timed cache by default. This fixes the issue where developers who are actively editing or deploying new versions of static files from don't see changes.
Cache-Control: no-cacheby default, orpublicifmax_age > 0.no-cachedoesn't actually mean "don't cache" (that would beno-store).cache_timeouttomax_age. I think this makes it clearer that the parameter directly affects theCache-Control: max-agevalue.environparameter required. It got added as optional when copying from Flask, but Flask's version would never be called without an activerequest. Withconditional=Trueit's required by default anyway.fixes #1882
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.