move send_file and send_from_directory to Werkzeug #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
move-send-file
branch
from
655edf7
to
3a06392
Compare
The implementations were moved to Werkzeug, Flask's functions become wrappers around Werkzeug to pass some Flask-specific values. cache_timeout is renamed to max_age. SEND_FILE_MAX_AGE_DEFAULT, app.send_file_max_age_default, and app.get_send_file_max_age defaults to None. This tells the browser to use conditional requests rather than a 12 hour cache. attachment_filename is renamed to download_name, and is always sent if a name is known. Deprecate helpers.safe_join in favor of werkzeug.utils.safe_join. Removed most of the send_file tests, they're tested in Werkzeug. In the file upload example, renamed the uploaded_file view to download_file to avoid a common source of confusion.
davidism
force-pushed
the
move-send-file
branch
from
3a06392
to
dc11cdb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The implementations were moved to Werkzeug (pallets/werkzeug#1850, pallets/werkzeug#1962). Flask's functions become wrappers around Werkzeug to pass some Flask-specific values.
cache_timeoutis renamed tomax_age.SEND_FILE_MAX_AGE_DEFAULT,app.send_file_max_age_default, andapp.get_send_file_max_agedefaults toNone. This tells the browser to use conditional requests rather than a 12 hour cache. (pallets/werkzeug#1886)attachment_filenameis renamed todownload_name, and is always sent if a name is known. (pallets/werkzeug#1884)Deprecate
helpers.safe_joinin favor ofwerkzeug.utils.safe_join.Removed most of the tests, they're tested in Werkzeug.
In the file upload example, renamed the
uploaded_fileview todownload_fileto avoid a common source of confusion.