typing: MultiDict.update accepts Iterable Mapping values. #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you also able to report the ordering to PyCharm as a bug? I've changed the target to 2.0.x. |
|
Could you add a changelog entry to note you've fixed the update method typing? |
MultiDict.__init__ correctly represents it, however the update was missing the iterable variant. Also, flipped the order of Iterable[V] and V fixes PyCharm's naive matching for generics. Mypy would accept both versions, however PyCharm would only try to infer Mapping V as the List. By listing it second it will first try to map to the Iterable[V].
MaicoTimmerman
force-pushed
the
multidict-update-typing
branch
from
4866501
to
736b811
Compare
|
@pgjones I've added a changelog entry. I'll try and make time to create a minimal-reproducable example to submit to PyCharm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiDict.__init__correctly represents it, however the update was missing theiterablevariant.Also, flipped the order of
Iterable[V]andVfixes PyCharm's naive matching for generics. Mypy would accept both versions, however PyCharm would only try to inferMapping'sVas theList. By listing it second it will first try to map to the Iterable[V].Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.