Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing: MultiDict.update accepts Iterable Mapping values. #2142

Merged
merged 1 commit into from Jun 2, 2021
Merged

typing: MultiDict.update accepts Iterable Mapping values. #2142

merged 1 commit into from Jun 2, 2021

Commits on Jun 2, 2021

  1. typing: MultiDict.update accepts Iterable Mapping values. 

    MultiDict.__init__ correctly represents it, however the update was
missing the iterable variant.

Also, flipped the order of Iterable[V] and V fixes PyCharm's naive
matching for generics. Mypy would accept both versions, however PyCharm
would only try to infer Mapping V as the List. By listing it second it
will first try to map to the Iterable[V].
    @MaicoTimmerman
    MaicoTimmerman committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    736b811 View commit details
    Browse the repository at this point in the history