clearer error message when ssl is not available #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooperlees
reviewed
Nov 7, 2021
| @@ -39,7 +39,10 @@ | |||
|
|
|||
| class _SslDummy: | |||
| def __getattr__(self, name: str) -> t.Any: | |||
| raise RuntimeError("SSL support unavailable") # noqa: B904 | |||
| raise RuntimeError( # noqa: B904 | |||
| "SSL is unavailable because this Python was not" | |||
There was a problem hiding this comment.
Suggested change
| "SSL is unavailable because this Python was not" | |
| "SSL is unavailable because this Python runtime was not" |
| raise RuntimeError("SSL support unavailable") # noqa: B904 | ||
| raise RuntimeError( # noqa: B904 | ||
| "SSL is unavailable because this Python was not" | ||
| " compiled with SSL support." |
There was a problem hiding this comment.
Suggested change
| " compiled with SSL support." | |
| " compiled with SSL/TLS support." |
|
Thanks, added the extra changes in ff94311. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @cooperlees in PyCQA/flake8-bugbear#190, the error message when SSL was unavailable was not very clear. Now it explains that Python wasn't compiled with SSL support.