Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: New Buttons, Inset label form Inputs #891

Merged
merged 42 commits into from
Apr 30, 2024
Merged

BREAKING CHANGE: New Buttons, Inset label form Inputs #891

merged 42 commits into from
Apr 30, 2024

Conversation

nathanyoung
Copy link
Member

Github Issue or Trello Card

This PR addresses this issue:

What type of change is this?

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updating documentation.
  • Updating deployment/build pipeline.
  • Updating Project Dependencies
  • Improving or adding to Test Coverage

Completeness Checklist

  • TESTS: My changes maintain the baseline required test coverage, as specified by code climate analysis.
  • DOCS: All new component work is covered in that component's Overview docs.
  • DOCS: All new component work is covered in a component Playground.
  • DOCS: All new visual changes or options are covered under relevant components' VisualTests.
  • My code has no linting or typescript compile warnings.
  • My work is tied to a Github issue and satisfies the acceptance criteria (if applicable) of the corresponding issue.

Quality Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

UI Checklist

  • I have conducted visual UAT on my changes/features.
  • My solution works well on desktop, tablet, and mobile browsers.

nathanyoung and others added 30 commits December 14, 2022 21:15
@nathanyoung
chore: react-select 3.1.0 to 4.3.1 (#811)
25adc30
@nathanyoung
Merge branch 'main' into beta
5610cc6
@nathanyoung
BREAKING CHANGE: New Buttons (#865)
935c361 
BREAKING CHANGE:

* wip

* more wip

* fix errors

* form label help text tokens

* mediamodal close button

* Update Theming.stories.mdx

* fix build

* Update Button.VisualTests.stories.tsx

* Update Button.VisualTests.stories.tsx

* cleanup
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
bb240e6 
# [1.0.0-beta.1](v0.157.7...v1.0.0-beta.1) (2024-02-02)

* BREAKING CHANGE: New Buttons (#865) ([935c361](935c361)), closes [#865](#865)

### BREAKING CHANGES

* * wip

* more wip

* fix errors

* form label help text tokens

* mediamodal close button

* Update Theming.stories.mdx

* fix build

* Update Button.VisualTests.stories.tsx

* Update Button.VisualTests.stories.tsx

* cleanup
@nathanyoung
fix(Button): secondary neutral hover color (#866)
dbde3f3
@semantic-release-bot
chore(release): 1.0.0-beta.2 [skip ci]
9c158ff 
# [1.0.0-beta.2](v1.0.0-beta.1...v1.0.0-beta.2) (2024-02-02)

### Bug Fixes

* **Button:** secondary neutral hover color ([#866](#866)) ([dbde3f3](dbde3f3))
@nathanyoung
feat(Button): tone prop (#867)
918eeea 
* add tone prop

* fix up

* update FileUpload

* Update FileUpload.Overview.stories.mdx

* Update Table.Overview.stories.mdx

* Update Toast.Overview.stories.mdx
@semantic-release-bot
chore(release): 1.0.0-beta.3 [skip ci]
f5f51ee 
# [1.0.0-beta.3](v1.0.0-beta.2...v1.0.0-beta.3) (2024-02-09)

### Features

* **Button:** tone prop ([#867](#867)) ([918eeea](918eeea))
@nathanyoung
fix(Button): loading state icon color (#868)
96c93c9 
* fix(Button): loading state icon color

* Update MediaModal.VisualTests.stories.tsx
@semantic-release-bot
chore(release): 1.0.0-beta.4 [skip ci]
afbc236 
# [1.0.0-beta.4](v1.0.0-beta.3...v1.0.0-beta.4) (2024-02-13)

### Bug Fixes

* **Button:** loading state icon color ([#868](#868)) ([96c93c9](96c93c9))
@nathanyoung
docs(Button): tone documentation (#869)
45223d0 
* Update Button.Overview.stories.mdx

* Update Button.Overview.stories.mdx
@semantic-release-bot
chore(release): 1.0.0-beta.5 [skip ci]
3675de8 
# [1.0.0-beta.5](v1.0.0-beta.4...v1.0.0-beta.5) (2024-02-13)
@nathanyoung
fix(FormControls): specify width 100 instead of relying on flex auto (#…
a78ba2e 
…870)
@semantic-release-bot
chore(release): 1.0.0-beta.6 [skip ci]
20c3fbb 
# [1.0.0-beta.6](v1.0.0-beta.5...v1.0.0-beta.6) (2024-02-13)

### Bug Fixes

* **FormControls:** specify width 100 instead of relying on flex auto ([#870](#870)) ([a78ba2e](a78ba2e))
@nathanyoung
feat(TextInputFloating): new component (#874)
a19211b 
* wip

* wip

* lint

* Create TextInputFloating.test.tsx

* style lint

* update prefix and suffix styles

* div wrapper

* safari workaround

* Update FormControls.stories.mdx

* Update FormTheming.stories.mdx

* Create TextInputFloating.Playground.stories.tsx

* visual tests
@semantic-release-bot
chore(release): 1.0.0-beta.7 [skip ci]
7e40be3 
# [1.0.0-beta.7](v1.0.0-beta.6...v1.0.0-beta.7) (2024-02-29)

### Features

* **TextInputFloating:** new component  ([#874](#874)) ([a19211b](a19211b))
@nathanyoung
fix(TextInputFloating): prefix/suffix focus styles, clear icon (#875)
7e90a7c 
* fix(TextInputFloating): prefix and suffix focus styling

* remove-light clear icon
@semantic-release-bot
chore(release): 1.0.0-beta.8 [skip ci]
2068200 
# [1.0.0-beta.8](v1.0.0-beta.7...v1.0.0-beta.8) (2024-03-01)

### Bug Fixes

* **TextInputFloating:** prefix/suffix focus styles, clear icon ([#875](#875)) ([7e90a7c](7e90a7c))
@nathanyoung
feat(SelectInputNativeFloating): new component (#877)
62dc894 
* feat(SelectInputNativeFloating): new component

* Update SelectInputNativeFloating.test.tsx

* helpText component

* use HelpText component everywhere

* wip

* Update FormControls.stories.mdx

* Update FormTheming.stories.mdx

* Update Toggle.tsx

* Update Toggle.tsx

* fix toggle alignment

* more documentation
@semantic-release-bot
chore(release): 1.0.0-beta.9 [skip ci]
7ff620a 
# [1.0.0-beta.9](v1.0.0-beta.8...v1.0.0-beta.9) (2024-03-06)

### Features

* **SelectInputNativeFloating:** new component ([#877](#877)) ([62dc894](62dc894))
@nathanyoung
feat(TextareaInputFloating): new component (#878)
c3e0b3a 
* feat(TextareaInputFloating): new component

* lint
@semantic-release-bot
chore(release): 1.0.0-beta.10 [skip ci]
8ae79e4 
# [1.0.0-beta.10](v1.0.0-beta.9...v1.0.0-beta.10) (2024-03-06)

### Features

* **TextareaInputFloating:** new component ([#878](#878)) ([c3e0b3a](c3e0b3a))
@nathanyoung
docs: floating and default input examples (#879)
d6de673
@semantic-release-bot
chore(release): 1.0.0-beta.11 [skip ci]
5a819da 
# [1.0.0-beta.11](v1.0.0-beta.10...v1.0.0-beta.11) (2024-03-06)
@nathanyoung
fix: rename floating inputs to inset (#880)
b13ab19 
* cleanup

* fix: rename floating inputs to inset

* lint
@semantic-release-bot
chore(release): 1.0.0-beta.12 [skip ci]
1ec3a59 
# [1.0.0-beta.12](v1.0.0-beta.11...v1.0.0-beta.12) (2024-03-07)

### Bug Fixes

* rename floating inputs to inset ([#880](#880)) ([b13ab19](b13ab19))
@nathanyoung
chore(deps): bump palmetto-design-tokens from 0.78.0 to 0.78.1 (#881)
f3f9cbc
@nathanyoung
feat(SelectInputs): make dropdown indicator match icon (#882)
3c9a80c 
* feat(SelectInputs): make dropdown indicator match icon

* Update SelectInputNativeInset.module.scss
@semantic-release-bot
chore(release): 1.0.0-beta.13 [skip ci]
03b4b45 
# [1.0.0-beta.13](v1.0.0-beta.12...v1.0.0-beta.13) (2024-03-15)

### Features

* **SelectInputs:** make dropdown indicator match icon ([#882](#882)) ([3c9a80c](3c9a80c))
@nathanyoung
fix(SelectInputInset): rename SelectInputNativeInset to SelectInputIn…
bfaacd7 
…set (#883)
semantic-release-bot and others added 10 commits March 15, 2024 18:41
@semantic-release-bot
chore(release): 1.0.0-beta.14 [skip ci]
89f0f64 
# [1.0.0-beta.14](v1.0.0-beta.13...v1.0.0-beta.14) (2024-03-15)

### Bug Fixes

* **SelectInputInset:** rename SelectInputNativeInset to SelectInputInset ([#883](#883)) ([bfaacd7](bfaacd7))
@nathanyoung
feat: update drop shadows (#885)
189b809 
* feat: update dropshadows

* prevent false positives
@semantic-release-bot
chore(release): 1.0.0-beta.15 [skip ci]
f1defda 
# [1.0.0-beta.15](v1.0.0-beta.14...v1.0.0-beta.15) (2024-04-05)

### Features

* update drop shadows  ([#885](#885)) ([189b809](189b809))
@nathanyoung
feat: update drop shadows (#886)
bc78fa2
@semantic-release-bot
chore(release): 1.0.0-beta.16 [skip ci]
4635701 
# [1.0.0-beta.16](v1.0.0-beta.15...v1.0.0-beta.16) (2024-04-05)

### Features

* update drop shadows ([#886](#886)) ([bc78fa2](bc78fa2))
@nathanyoung @dependabot
build: package updates (#888)
dc80427 
* build(deps): bump tar from 6.1.14 to 6.2.1 (#887)

Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.14 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.14...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nathan Young <1447339+nathanyoung@users.noreply.github.com>

* build(deps): bump express from 4.18.2 to 4.19.2 (#884)

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nathan Young <1447339+nathanyoung@users.noreply.github.com>

* build(deps): bump es5-ext from 0.10.53 to 0.10.63 (#872)

Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.53 to 0.10.63.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.53...v0.10.63)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@semantic-release-bot
chore(release): 1.0.0-beta.17 [skip ci]
b403ae2 
# [1.0.0-beta.17](v1.0.0-beta.16...v1.0.0-beta.17) (2024-04-12)
@nathanyoung
bump(deps): package bumps (#890)
7fc6188 
* bump(deps): dependency updates

* update chromatic

* Update yarn.lock

* babel

* Update yarn.lock
@nathanyoung
Merge branch 'main' into beta
bfd1714
@semantic-release-bot
chore(release): 1.0.0-beta.18 [skip ci]
427a18a 
# [1.0.0-beta.18](v1.0.0-beta.17...v1.0.0-beta.18) (2024-04-30)

### Features

* update drop shadows  ([#885](#885)) ([7aae6b1](7aae6b1))
codeclimate[bot]
codeclimate bot reviewed Apr 30, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10789 lines exceeds the maximum allowed for the inline comments feature.

@nathanyoung nathanyoung marked this pull request as ready for review April 30, 2024 16:13
codeclimate[bot]
codeclimate bot reviewed Apr 30, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10806 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 30, 2024

Code Climate has analyzed commit 5920f0d and detected 21 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 19

The test coverage on the diff in this pull request is 95.4% (95% is the threshold).

This pull request will bring the total coverage in the repository to 97.9%.

View more on Code Climate.

@nathanyoung nathanyoung merged commit 2a48b37 into main Apr 30, 2024
11 of 12 checks passed
@nathanyoung nathanyoung deleted the beta branch April 30, 2024 16:43
palmettogithub pushed a commit that referenced this pull request Apr 30, 2024
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
b9a6cae 
# [1.0.0](v0.158.2...v1.0.0) (2024-04-30)

* BREAKING CHANGE: New Buttons, Inset label form Inputs (#891) ([2a48b37](2a48b37)), closes [#891](#891) [#811](#811) [#866](#866) [#866](#866) [#867](#867) [#867](#867) [#868](#868) [#868](#868) [#869](#869) [#870](#870) [#870](#870) [#874](#874) [#874](#874) [#875](#875) [#875](#875) [#877](#877) [#877](#877) [#878](#878) [#878](#878) [#879](#879) [#880](#880) [#880](#880) [#881](#881) [#882](#882) [#882](#882) [#883](#883) [#883](#883) [#885](#885) [#885](#885) [#886](#886) [#886](#886) [#888](#888) [#887](#887)

### BREAKING CHANGES

* New Buttons (#865)
* * wip

* more wip

* fix errors

* form label help text tokens

* mediamodal close button

* Update Theming.stories.mdx

* fix build

* Update Button.VisualTests.stories.tsx

* Update Button.VisualTests.stories.tsx

* cleanup

* chore(release): 1.0.0-beta.1 [skip ci]

# [1.0.0-beta.1](v0.157.7...v1.0.0-beta.1) (2024-02-02)
* New Buttons (#865) ([935c361](935c361)), closes [#865](#865)

### BREAKING CHANGES

* * wip

* more wip

* fix errors

* form label help text tokens

* mediamodal close button

* Update Theming.stories.mdx

* fix build

* Update Button.VisualTests.stories.tsx

* Update Button.VisualTests.stories.tsx

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nathanyoung @semantic-release-bot