Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup IDisposable aspects #1

Open
pamidur opened this issue Oct 18, 2014 · 2 comments
Open

Cleanup IDisposable aspects #1

pamidur opened this issue Oct 18, 2014 · 2 comments
Labels
enhancement
Milestone
3.0

Comments

@pamidur
Copy link
Owner

pamidur commented Oct 18, 2014

No description provided.

@pamidur pamidur added this to the 1.0 Release milestone Oct 18, 2014
@pamidur
Copy link
Owner Author

pamidur commented Feb 10, 2015

We need to discuss it. It could be done if target is disposable and aspect scope is instance. Right?

@YuriyIvon
Copy link
Collaborator

Right, I would even disable setting scope "Class" for aspects with IDisposable interface. Apart from that, we will have to inject IDisposable interface and its implementation automatically to targets not having it. If Dispose() already exists, it may happen that calls to aspect methods were injected into it, so we have to do the cleanup only after those methods were called.

@pamidur pamidur modified the milestones: Future releases, 1.0 Release Jul 11, 2015
@pamidur pamidur modified the milestones: Future releases, 3.0 Sep 20, 2019
pamidur pushed a commit that referenced this issue Dec 20, 2021
@StefH
[Security] Update samples.yml to use actions/checkout@v2 (#1) (#168)
a81f267 
The workflow samples.yml is referencing action actions/checkout using references v1. 

However this reference is missing the commit a6747255bd19d7a757dbdda8c654a9f84db19839 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.
@crazy-zzking crazy-zzking mentioned this issue Nov 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@pamidur @YuriyIvon