Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Why GetInstance method for Factory should be static? #216

Closed
IbrahimElshafey opened this issue May 24, 2023 · 3 comments
Closed

Comments

@IbrahimElshafey
Copy link

Why not something similar to JobActivator ? to enable easy use.

@pamidur
Copy link
Owner

pamidur commented May 24, 2023 via email

@pamidur
Copy link
Owner

pamidur commented Jul 7, 2023

It took me some time to understand. The reason is that Aspect Injectior might not be able to instantiate the factory class.
Inside static GetInstance method you may hook it to any DI you like though

@pamidur
Copy link
Owner

pamidur commented Jul 7, 2023

In future I plan for better DI frameworks support.
For now I'll close the issue, but feel free to reopen if needed

@pamidur pamidur closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants