Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farm page redesign #211

Closed
wants to merge 7 commits into from
Closed

Farm page redesign #211

wants to merge 7 commits into from

Conversation

PfanP
Copy link

@PfanP PfanP commented Dec 20, 2020

  • remove active/inactive page from farm page
  • remove image from farm page

@hachiojidev hachiojidev mentioned this pull request Dec 21, 2020
Merged
RabbitDoge
RabbitDoge suggested changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@RabbitDoge RabbitDoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to pull the icons from the UIkit.
Please fix the lint warnings before the review.

hachiojidev
hachiojidev suggested changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@hachiojidev hachiojidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you work.

Please check the comments below and let us know if you have any questions.

  • I have added the relevant icons to the UI Kit here feat(icons): Additional icons pancake-uikit#103. Please use these when it is released (it should shortly)
  • Please fix linting errors
  • Clicking on the view switcher (table view, card view) does not change the layout for me
  • The search does not seems to work. Hitting enter submits the form. Can you give us a brief explanation of the intended behavior is supposed to be?
  • Missing the "show all" toggle

There are some issues I see with the layout on mobile/desktop.
image
image

src/components/Page/Page.tsx Outdated Show resolved Hide resolved
src/components/layout/Grid.tsx Outdated Show resolved Hide resolved
src/views/Farms/Farms.tsx Outdated Show resolved Hide resolved
src/views/Farms/components/Searchbox.tsx Outdated Show resolved Hide resolved
src/views/Farms/Farms.tsx Outdated Show resolved Hide resolved
@PfanP
Copy link
Author

PfanP commented Dec 21, 2020

Thanks for your review @hachiojidev , just wanted to inform it's not final version. I wanted to get feedback if I'm on right way.
I will fix those feedbacks

@hachiojidev
Copy link
Contributor

Thanks for your review @hachiojidev , just wanted to inform it's not final version. I wanted to get feedback if I'm on right way.
I will fix those feedbacks

Okay, no worries. We are in the process of writing out some PR guidelines. In the future please set the PR as a draft so we know it is a WIP.

@PfanP
Copy link
Author

PfanP commented Dec 21, 2020

Thanks for your review @hachiojidev , just wanted to inform it's not final version. I wanted to get feedback if I'm on right way.
I will fix those feedbacks

Okay, no worries. We are in the process of writing out some PR guidelines. In the future please set the PR as a draft so we know it is a WIP.

Ok

@PfanP PfanP marked this pull request as draft December 21, 2020 02:31
hachiojidev
hachiojidev reviewed Dec 22, 2020
View reviewed changes
src/views/Farms/Farms.tsx
Comment on lines +91 to +94
const StyledPage = styled(Page)`
@media (min-width: 968px) {
width: 60vw;
margin: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the theme values from the UI Kit

${({ theme }) => theme.mediaQueries.sm} {

}

They can be found here
https://github.com/pancakeswap/pancake-uikit/blob/master/src/theme/base.ts

@RabbitDoge RabbitDoge deleted the farm-rework-bounty branch January 13, 2021 08:57
loganbek pushed a commit to loganbek/kogefarm-frontend that referenced this pull request Oct 15, 2021
@0xRektora
pancakeswap#211: Added react-intersection-observer
897e2cd
loganbek pushed a commit to loganbek/kogefarm-frontend that referenced this pull request Oct 15, 2021
@0xRektora
pancakeswap#211: Lazily load vaults element, for increased perf ⬆⬆
8d56e2c
loganbek pushed a commit to loganbek/kogefarm-frontend that referenced this pull request Oct 15, 2021
@0xRektora
pancakeswap#211: Adapted Row to include OnInView callback
c2bf96e
loganbek pushed a commit to loganbek/kogefarm-frontend that referenced this pull request Oct 15, 2021
@0xRektora
pancakeswap#211: Fixed InView wrapping issue
7e084b9
loganbek pushed a commit to loganbek/kogefarm-frontend that referenced this pull request Oct 15, 2021
@0xRektora
Merge pull request pancakeswap#213 from kogecoin/211-increase-perform…
0d9806b 
…ance-by-lazily-loading-vaults

fix pancakeswap#211, fix pancakeswap#101, fix pancakeswap#69
loganbek added a commit to loganbek/kogefarm-frontend that referenced this pull request Oct 15, 2021
@0xRektora @loganbek
@adbertram @kogecoindev
Release 2.0.2 (pancakeswap#238)
b245023 
* updated package.json version

* 193: Show divider instead of sidebar meny content when pushed off

* rm circle icon

* 161: Refactored and fixed column sorting

* pancakeswap#211: Added react-intersection-observer

* pancakeswap#211: Lazily load vaults element, for increased perf ⬆⬆

* pancakeswap#211: Adapted Row to include OnInView callback

* pancakeswap#211: Fixed InView wrapping issue

* pancakeswap#215: Fixed high APY numbers overflow

* pancakeswap#190: Set the Select DropdownContainer width to 100%

* pancakeswap#190: Added sorting for mobile users

* added placeholders

* added placeholders

* removed test LP tokens addrs

* 129-logo-link-add-text

* Revert "Merge pull request pancakeswap#217 from kogecoin/190-enable-apy-sorting-in-mobile"

This reverts commit f8ad08b, reversing
changes made to daf8733.

* Revert "129-logo-link-add-text"

This reverts commit aa076a6.

* Revert "Revert "Merge pull request pancakeswap#217 from kogecoin/190-enable-apy-sorting-in-mobile""

This reverts commit c3042ef.

* Revert "Revert "129-logo-link-add-text""

This reverts commit f722978.

* Update README.md

* 12 decimals

* cleanup commment

* fix logo text link

* format

* removed unwanted test data

* removed test data

* move iris to inactive

* remove empty inactive vaults

* Add contracts for moonriver

- MultiCall, verified on PolygonScan then deployed on MoonRiver
- farms_mvr.ts: USDC-Dai (Solar)
- Tokens: added addresses for chain 1285 for USDC, Dai, Solar

* update to polygon-rpc

* add some other RPCs to rotation

* get rid of beware labs since it seems to be down too

* add back beware labs spelling error

* pancakeswap#229: Fixed multisearch with platform filter

* Revert "Revert "Revert "129-logo-link-add-text"""

This reverts commit 543431e.

* Reverted changes that introduced bug from pancakeswap#129

* 194: Reduced navbar tooltips size of  by half

* 175: Removed withdrawal cancel button outline

* add back infura

* 107 add youtube link (pancakeswap#230)

* add menu entry

* svg

* pancakeswap#215: Rounding up APYs greater than billions

* pancakeswap#234: Activate staked only when toggle to inactive farms

* fix atricrypto APRs

* update trading fee for curve

* pancakeswap#215: Added million as a rounded number

* Quickfix: redirecting only if on prod

Co-authored-by: Logan Bek <loganbek@gmail.com>
Co-authored-by: Adam Bertram <adbertram@gmail.com>
Co-authored-by: dhzh <88013318+kogecoindev@users.noreply.github.com>
0xjojoex pushed a commit to 0xjojoex/pancake-frontend that referenced this pull request Jan 25, 2022
@hachiojidev
feat(icons): Wait, Timer, Play icon (pancakeswap#211)
ba5e8be
0xjojoex pushed a commit to 0xjojoex/pancake-frontend that referenced this pull request Jan 25, 2022
@ChefKai
chore: List C98 (pancakeswap#211)
1e4035c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hachiojidev hachiojidev hachiojidev requested changes

@RabbitDoge RabbitDoge RabbitDoge requested changes

@ChefMomota ChefMomota Awaiting requested review from ChefMomota ChefMomota will be requested when the pull request is marked ready for review ChefMomota is a code owner

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi Chef-Yogi will be requested when the pull request is marked ready for review Chef-Yogi is a code owner

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson will be requested when the pull request is marked ready for review chefjackson is a code owner

@ChefJerry ChefJerry Awaiting requested review from ChefJerry ChefJerry will be requested when the pull request is marked ready for review ChefJerry is a code owner

@thechefpenguin thechefpenguin Awaiting requested review from thechefpenguin thechefpenguin will be requested when the pull request is marked ready for review thechefpenguin is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric will be requested when the pull request is marked ready for review chef-eric is a code owner

@chef-ryan chef-ryan Awaiting requested review from chef-ryan chef-ryan will be requested when the pull request is marked ready for review chef-ryan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PfanP @hachiojidev @RabbitDoge