Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uikit): BottomNav #279

Merged

Conversation

chenxsan
Copy link
Contributor

@chenxsan chenxsan commented Sep 16, 2021

When I was scrolling the new home page of pancakeswap on my cellphone, I just noticed that the bottom navbar was not handled well on iPhone:

This pull request should fix the problem with env().

Copy link
Contributor

@hachiojidev hachiojidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@0xCorgi I will let you merge this.

Copy link
Contributor

@0xCorgi 0xCorgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix @chenxsan

@hachiojidev hachiojidev merged commit 5d75877 into pancakeswap:master Sep 16, 2021
@chenxsan chenxsan deleted the bugfix/fix-bottom-nav-style branch September 16, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants