Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel-less emitters bound synchronously #2

Closed
pancsta opened this issue Jan 12, 2024 · 0 comments · Fixed by #7
Closed

Channel-less emitters bound synchronously #2

pancsta opened this issue Jan 12, 2024 · 0 comments · Fixed by #7
Labels
breaking Breaking API change enhancement New feature or request p:2 Medium priority

Comments

@pancsta
Copy link
Owner

pancsta commented Jan 12, 2024 •
edited
Loading

Initially emitters were supposed to be public, but once the handling complexity grew, it became a dangerous idea.

Since all the emitter handling code is in the AM itself, there's no point in talking over channels. This will effectively deprecate HandlerBinding, simplify machine inits and related internal code.

Blocked by #3.
@pancsta pancsta added enhancement New feature or request p:2 Medium priority labels Jan 12, 2024
pancsta added a commit that referenced this issue Jan 15, 2024
@pancsta
feat: channel-less emitters (#2)
5b2c6df
@pancsta pancsta mentioned this issue Jan 15, 2024
Merged
pancsta added a commit that referenced this issue Jan 18, 2024
@pancsta
feat: channel-less emitters (#2)
f97bb90
@pancsta pancsta added the breaking Breaking API change label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Breaking API change enhancement New feature or request p:2 Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: synchronous emitter bindings pancsta/asyncmachine-go
1 participant
@pancsta