Mips64 support for syscalls2 and OSI_linux #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFasano
force-pushed
the
mips64osi
branch
2 times, most recently
from
e32183d
to
778b934
Compare
AndrewFasano
requested review from
jamcleod
and removed request for
off-by-1-error
…ss of 32 or 64 bit values
Also adds some more macro-enabled debug prints
…nitial MIPS support for O32, N32, N64 ABIs
…cal functions Long term we might need a better design, but this seems to be sufficient for mips o32/n32/n64 ABIs. When two callnos map to the same function name (even with different signatures) remove duplicate handling logic. We may wish to improve this in the future so users can request a specific variant of a syscall, but this is just a cleaner version of our existing logic. Templates changed to clearly show details of multiple callnos/prototypes or to leave generated code unchanged if there's only a single callno These changes may cause issues when re-generating signatures for other architectures, if it happens let me know.
jamcleod
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends syscalls2 profile generation logic to support multiple ABIs where multiple syscall numbers can map to the same syscall. Adds logic into syscalls2 core logic for reading arguments to support multiple ABIs.
Adds n64 and n32 support for MIPS/MIPS64.
Adds a new macro for endian adjustment in OSI_linux inspired by Mark's code in #1320 to make the compiler pick between bswap32/bswap64 depending on the size of the object being flipped.
Adds MIPS64 to the default build list in docker.