Slight tweaks and attempt 2 on centralizing Python Packages #1498
Conversation
…re warnings of outdated nodejs. Also, removed from Pypanda README that pypi package would be outdated now that we have CI to automatically update pypi package
…o docker images, just use target to stop at install, export wheel, and then continue to final build to creating the debian package. It seems like my attempt to centralize all python requirements to requirements.txt failed last time, but I am giving it another shot by forcing it pretty early within the Docker Image build to force install all requirements.txt. Finally, slight documentation tweaks now that pypanda is a thing, and the debian packages are a thing too
|
I was a bit surprised to notice sphinx being installed in Ubuntu 20 and 22, but not 18. After a bit of poking around, seems like Sphinx is for document formatting. Wouldn't the better place to install sphinx be in the documentation workflow? https://pypi.org/project/Sphinx/#description Based on the Workflow file, this seems to confirm my hunch. |
…he more I think about it, it feels better within build requirements as technically, this should have nothing to do with pypanda on its own. Also, I do notthink install ubuntu needs to repeat installing pip and cffi
|
Wait is And in my original attempt to refactor, I removed |
|
Oops, realized I accidentally broke the install_ubuntu.sh, it should work now with the whole install from Debian package now. I'm wondering if anything can be done about the warnings? Should we remove the $SUDO from the pip stuff?
|
|
Up to you if we should also try to fix the publish_deb.yaml workflow in this PR, seems like it is tripping up on release name. Any tips on what to try to tweak on tag_name argument? I would suspect it would be similar to the work done by you and Luke earlier once pypanda was now automatically deployed to Pip. But I'm not sure what versioning rules you might have for publish_deb.yaml https://github.com/panda-re/panda/actions/runs/9185148186 |
|
Also, wanted to ask if you'd be OK to test the organization secret instead for pushing to DockerHub? I figure we should know if it works or not. The hope is, when LAVA is revived fully, we can use this to also push a LAVA docker image to panda-re dockerhub too. |
…tly on osx. It is likely broken, but lets avoid bad habits and keep everything in one place
…eplaced Travis fully
|
Also, any tips how to upgrade this to point to Ubuntu 18 64-bits? Think this minor fix is probably overdue as well. https://github.com/panda-re/panda/blob/dev/.github/workflows/parallel_tests.yml#L117-L119 |
Update to latest master
…uld by default build pypanda like the docker image does
…so it can be passed around for testing
|
I will do two PRs, one for updating Actions versions, and I want to preliminary test uploading Docker Images. In another PR, ill take on the install script cleanups |
Few things:
1- Most important, I updated the @ version for GitHub action workflows, it seems some are going to EOL soon, so to avoid anything breaking, might as well fix it for you now.
2- Slight tweaks to documentation, as now there are consistent updates to pip for PyPanda and the Debian Packages.
3- Install_Ubuntu.sh now grabs the Debian Package like from Docker Build
4- I noticed it seems something breaks if python3- stuff was removed from the builds, so I am going to try again to put everything in the requirements.txt and install them pretty early, so hopefully there are no breaks. I just figure it is good practice to try to have one source of truth when installing everything.
I should note that setup.sh from Debian Package worked on my WSL, Luke just make sure this hopefully correctly centralized the Python requirements for Panda and PyPanda