Markdown compile documentation #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added generated syscall headers
Output now includes mapping to prov tracer syscall numbers.
Conflicts: qemu/build.sh
Conflicts: qemu/build.sh qemu/panda_plugins/config.panda
They are currently broken.
They are currently broken.
All ops are now decoded by distorm.
added timestamp for ins_exec_callback() now printing CR3 on the output
Conflicts: docs/compile.txt
Conflicts: qemu/build.sh qemu/panda_plugins/config.panda
Oops! typo.
variable. Makes reusing them from custom makefiles easier.
Added symlink to linux_vmi.
added 2 commits
October 20, 2014 20:06
procinfo.c was included as a commented section inside DECAF_linux_vmi.c. Added Makefile and Documentation for procinfo. Fixed compilation warnings due to pointer to int casts.
added 13 commits
October 23, 2014 00:04
Default now is initialization from file. .gitignore for kernel info module.
Conflicts: qemu/panda_plugins/config.panda
Debug FILE* added.
|
Sorry this is taking so long to get merged -- it's quite a few changes at once. I'll try to find some time early next week to go through and review them. In the future though, could you try to bundle related changes into individual pull requests? |
|
Hi @moyix. No worries about the delay. There were also a couple of additions to the documentation after my merge request. I'll add those to the markdown docs after you merge. After making sure that markdown/txt docs are in sync, the txt docs could go to eliminate the need for further syncing in the future. |
|
Will break into smaller commits that are easier to review. |
|
Thank you! |
AndrewFasano
pushed a commit
that referenced
this pull request
Oct 16, 2023
Both virtio-blk and virtio-scsi use virtio_queue_empty() as the
loop condition in VQ handlers (virtio_blk_handle_vq,
virtio_scsi_handle_cmd_vq). When a device is marked broken in
virtqueue_pop, for example if a vIOMMU address translation failed, we
want to break out of the loop.
This fixes a hanging problem when booting a CentOS 3.10.0-862.el7.x86_64
kernel with ATS enabled:
$ qemu-system-x86_64 \
... \
-device intel-iommu,intremap=on,caching-mode=on,eim=on,device-iotlb=on \
-device virtio-scsi-pci,iommu_platform=on,ats=on,id=scsi0,bus=pci.4,addr=0x0
The dead loop happens immediately when the kernel boots and initializes
the device, where virtio_scsi_data_plane_handle_cmd will not return:
> ...
> #13 0x00005586602b7793 in virtio_scsi_handle_cmd_vq
> #14 0x00005586602b8d66 in virtio_scsi_data_plane_handle_cmd
> #15 0x00005586602ddab7 in virtio_queue_notify_aio_vq
> #16 0x00005586602dfc9f in virtio_queue_host_notifier_aio_poll
> #17 0x00005586607885da in run_poll_handlers_once
> #18 0x000055866078880e in try_poll_mode
> #19 0x00005586607888eb in aio_poll
> #20 0x0000558660784561 in aio_wait_bh_oneshot
> #21 0x00005586602b9582 in virtio_scsi_dataplane_stop
> #22 0x00005586605a7110 in virtio_bus_stop_ioeventfd
> #23 0x00005586605a9426 in virtio_pci_stop_ioeventfd
> #24 0x00005586605ab808 in virtio_pci_common_write
> #25 0x0000558660242396 in memory_region_write_accessor
> #26 0x00005586602425ab in access_with_adjusted_size
> #27 0x0000558660245281 in memory_region_dispatch_write
> #28 0x00005586601e008e in flatview_write_continue
> #29 0x00005586601e01d8 in flatview_write
> #30 0x00005586601e04de in address_space_write
> #31 0x00005586601e052f in address_space_rw
> #32 0x00005586602607f2 in kvm_cpu_exec
> #33 0x0000558660227148 in qemu_kvm_cpu_thread_fn
> #34 0x000055866078bde7 in qemu_thread_start
> #35 0x00007f5784906594 in start_thread
> #36 0x00007f5784639e6f in clone
With this patch, virtio_queue_empty will now return 1 as soon as the
vdev is marked as broken, after a "virtio: zero sized buffers are not
allowed" error.
To be consistent, update virtio_queue_empty_rcu as well.
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20180910145616.8598-2-famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
MarkMankins
pushed a commit
to MarkMankins/panda
that referenced
this pull request
Dec 18, 2023
…o_ace-stable ACE-538 and ACE-781 merge to ace stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compile instructions are now in markdown format. I have also added instructions for fetching LLVM, so the steps can be run without additional googling.
Text format remains, but should probably be removed if we keep markdown.
Other stuff:
inlinebeing already being defined. This is fixed by adding an#undefbefore defining it inosdep.h.build.sh(addresses issue Don't force GCC 4.7 #11).build.sh..gitignorenow hides the llvm/distorm dirs.