Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mayaegg: Fix animations not being created during egg traversal #1004

Closed
wants to merge 2 commits into from

Conversation

darktohka
Copy link
Contributor

Issue description

The maya2egg utilities do not convert any animations from the EGG format back to the Maya format when used.

This even happens when the "-a" flag is provided to enable animation translations.

Solution description

This is a regression that was introduced by the commit 7543449.

Simply put, a debug print function was removed, but to prevent a compiler warning because of an unused variable, the "GetAnim" method was also removed.

But this is the method that creates the animation entry in the table in the first place!

I've reintroduced this piece of code, and now animations are now converted back to the Maya format correctly.

I've also silenced another compiler warning.

Checklist

I have done my best to ensure that…

  • …I have familiarized myself with the CONTRIBUTING.md file
  • …this change follows the coding style and design patterns of the codebase
  • …I own the intellectual property rights to this code
  • …the intent of this change is clearly explained
  • …existing uses of the Panda3D API are not broken
  • …the changed code is adequately covered by the test suite, where possible.

@rdb rdb added the bug label Aug 31, 2020
@rdb rdb added this to the 1.10.7 milestone Aug 31, 2020
Copy link
Member

@rdb rdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, who knew carelessly commenting out code to squelch warning messages could be a bad idea?

Thanks a lot for catching this!

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #1004 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
+ Coverage   15.11%   15.13%   +0.02%     
==========================================
  Files        3704     3704              
  Lines      356367   356377      +10     
==========================================
+ Hits        53855    53950      +95     
+ Misses     302512   302427      -85     
Impacted Files Coverage Δ
panda/src/pgraph/lightAttrib.cxx 33.33% <0.00%> (-0.18%) ⬇️
panda/src/putil/bamCache.cxx 34.45% <0.00%> (+0.17%) ⬆️
panda/src/putil/uniqueIdAllocator.cxx 76.00% <0.00%> (+76.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b655aa8...7304d0c. Read the comment docs.

@rdb rdb added regression and removed bug labels Aug 31, 2020
@rdb rdb closed this in 1f504f6 Sep 1, 2020
@darktohka darktohka deleted the bugfix/maya-anims branch September 2, 2020 07:45
lachbr pushed a commit to lachbr/panda3d that referenced this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants