Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direct: Use explicitly Vec3F in calls to addData3f to avoid crash on double precision builds #1365

Closed
wants to merge 1 commit into from

Conversation

el-dee
Copy link
Contributor

@el-dee el-dee commented Sep 2, 2022

Issue description

When opening the BufferViewer with Panda3D compiled with double precision float enabled, the app crashes as Vec3 is actually Vec3D and addData3f() expect Vec3F

Solution description

Trivial fix that replace Vec3 with Vec3F

Checklist

I have done my best to ensure that…

  • …I have familiarized myself with the CONTRIBUTING.md file
  • …this change follows the coding style and design patterns of the codebase
  • …I own the intellectual property rights to this code
  • …the intent of this change is clearly explained
  • …existing uses of the Panda3D API are not broken
  • …the changed code is adequately covered by the test suite, where possible.

@rdb rdb added this to the 1.10.13 milestone Sep 2, 2022
@rdb rdb added bug direct For problems in `direct` as opposed to the engine core labels Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1365 (e809f57) into master (d239f48) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1365   +/-   ##
=======================================
  Coverage   16.10%   16.10%           
=======================================
  Files        3740     3740           
  Lines      363744   363744           
=======================================
  Hits        58594    58594           
  Misses     305150   305150           
Impacted Files Coverage Δ
direct/src/showbase/BufferViewer.py 20.57% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rdb
Copy link
Member

rdb commented Sep 2, 2022

Oops, the timing is unfortunate, since I had already reached the point of no return for the 1.10.12 release at the time you filed this PR. It will have to go into 1.10.13, with my apologies for the regression.

Thanks!

@rdb rdb added regression and removed bug labels Sep 2, 2022
@rdb rdb closed this in e30d88d Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
direct For problems in `direct` as opposed to the engine core regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants