Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getPlayMode() for actor and anim interface #1647

Merged
merged 1 commit into from May 14, 2024

Conversation

Wizzerinus
Copy link
Contributor

Issue description

As of right now there is not a way to know in which way an Actor is currently playing an animation (playing, looping, etc.) This PR fixes it.

Solution description

I've published a getter for play_mode in AnimInterface and exposed a helper on Actor. since getAnimControls() didn't used to return controls that are not playing anything, it made the helper not work in Pose mode, so I added an optional argument to control that.

Checklist

I have done my best to ensure that…

  • …I have familiarized myself with the CONTRIBUTING.md file
  • …this change follows the coding style and design patterns of the codebase
  • …I own the intellectual property rights to this code
  • …the intent of this change is clearly explained
  • …existing uses of the Panda3D API are not broken
  • …the changed code is adequately covered by the test suite, where possible.

Copy link
Member

@rdb rdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rdb rdb enabled auto-merge (rebase) May 14, 2024 08:14
@rdb rdb merged commit 3ffcce2 into panda3d:master May 14, 2024
16 checks passed
@Wizzerinus Wizzerinus deleted the get-actor-play-mode branch May 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants