Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back default model loading #40

Closed
wants to merge 2 commits into from
Closed

Add back default model loading #40

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2015

How does this bother anybody? This is a very useful feature.. especially when you already have a project with tons of DirectDialogs that you haven't set a model for.

Why was this removed?

Daniel added 2 commits June 17, 2015 18:58
How does this bother anybody? This is a very useful feature.. especially when you already have a project with tons of DirectDialogs that you haven't set a model for.

Why was this removed?
@rdb
Copy link
Member

rdb commented Jul 6, 2015

This change was submitted by Thaumaturge, who (rightly) felt that DirectDialog should not load an ugly texture and have external dependencies by default.

But you're right, it would be preferable if the default dialog geom setting would still function. We should instead default the default dialog geom to None rather than circumvent this mechanism entirely. We might also need to have a setting for default relief, or something, then, or automatically use a relief in absence of a default geom.

@rdb
Copy link
Member

rdb commented Nov 24, 2015

Sorry for taking a while to get to this. I've just checked in a fix that allows setting the default geom, using something like:

DGG.setDefaultDialogGeom(loader.loadModel('models/gui/dialog_box_gui')

Thanks!

@rdb rdb closed this Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant