Python2 code remove from deploy_stub #892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdb
reviewed
Mar 30, 2020
|
|
||
| if (Py_VerboseFlag) | ||
| fprintf(stderr, "Python %s\n%s\n", | ||
| Py_GetVersion(), Py_GetCopyright()); |
There was a problem hiding this comment.
Any particular reason why you have removed these last three lines, which don't seem to be related to Python 2/3? Or were these removed by mistake?
There was a problem hiding this comment.
I found those lines were under #if condition starting from line 433. So I thought to remove these also.
There was a problem hiding this comment.
The #if condition starting on line 433 ends on line 484.
There was a problem hiding this comment.
Ok! I have corrected the changes.
lachbr
pushed a commit
to lachbr/panda3d
that referenced
this pull request
Sep 24, 2020
Closes panda3d#892 Co-authored-by: rdb <git@rdb.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.