New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError in FY5253.rollback() #14774

Closed
ronif opened this Issue Nov 30, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@ronif

ronif commented Nov 30, 2016

Hi,

I'm trying to do North American (Year,WeekOfYear) <-> Period (W-SAT) conversions, for calculations involving fiscal year week numbers, etc. From what I understand pandas.offsets.FY5253 can be used for this, but I'm getting a weird assertion error than should probably not happen.

Code

import pandas as pd
fy = pd.offsets.FY5253(n=1, weekday=5, startingMonth=12, variation='nearest')
fy.rollback(pd.Timestamp('2004-01-01'))

Expected Output

I think the output should be equal to the one you get with

fy.rollback(pd.Timestamp('2003-12-31'))

which is

Timestamp('2002-12-28 00:00:00')

Output of pd.show_versions()

commit: None
python: 2.7.12.final.0
python-bits: 64
OS: Linux
OS-release: 4.2.0-35-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8

pandas: 0.19.1
nose: 1.3.7
pip: 8.1.2
setuptools: 28.7.1
Cython: 0.23.4
numpy: 1.11.2
scipy: 0.17.1
statsmodels: 0.6.1
xarray: None
IPython: 4.1.2
sphinx: 1.3.5
patsy: 0.4.0
dateutil: 2.6.0
pytz: 2016.7
blosc: None
bottleneck: 1.0.0
tables: 3.2.2
numexpr: 2.5
matplotlib: 1.5.1
openpyxl: 2.3.2
xlrd: 0.9.4
xlwt: 1.0.0
xlsxwriter: 0.8.4
lxml: 3.6.0
bs4: 4.4.1
html5lib: None
httplib2: 0.9.2
apiclient: 1.4.2
sqlalchemy: 1.0.12
pymysql: None
psycopg2: 2.6.1 (dt dec pq3 ext)
jinja2: 2.7.3
boto: 2.38.0
pandas_datareader: None

@jbrockmendel

This comment has been minimized.

Member

jbrockmendel commented Nov 28, 2017

@ronif I've got a bugfix that handles the example you gave. Do you happen to have an example that fails on rollforward? I think there may be a symmetric bug.

jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Nov 28, 2017

@jreback jreback added the Bug label Nov 28, 2017

@jreback jreback added this to the 0.22.0 milestone Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment