-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix for FY5253 case with bunched yearends #18550
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18550 +/- ##
==========================================
- Coverage 91.35% 91.31% -0.04%
==========================================
Files 164 164
Lines 49802 49804 +2
==========================================
- Hits 45496 45478 -18
- Misses 4306 4326 +20
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18550 +/- ##
==========================================
- Coverage 91.59% 91.58% -0.02%
==========================================
Files 153 153
Lines 51221 51223 +2
==========================================
- Hits 46917 46911 -6
- Misses 4304 4312 +8
Continue to review full report at Codecov.
|
cc @cancan101 if you could have a look / try out. |
release note pls. |
Ping. |
dt = Timestamp('2004-01-01') | ||
assert fy.rollback(dt) == Timestamp('2002-12-28') | ||
assert (-fy).apply(dt) == Timestamp('2002-12-28') | ||
assert dt - fy == Timestamp('2002-12-28') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add from the OP: fy.rollback(pd.Timestamp('2003-12-31'))
(which I think is the same result) as well
cc @ronif can you have a look. |
Just rebased and pushed; no new changes. |
thanks |
Also achieves coverage for one of the uncovered branches in
FY5253.apply
git diff upstream/master -u -- "*.py" | flake8 --diff