VIS: don't modify matplotlib units registry globally

[jorisvandenbossche]

Possible follow-up for #18307, see comment there: #18307 (comment) and #18307 (comment) for the details.

Idea would be to only register our converters when we are plotting ourselves, so people plotting directly with matplotlib (plt.plot(..) or ax.plot(..) don't use our converters by default (they can still register them manually with the option).

[TomAugspurger]

Pushing to 0.24.

[jreback]

@TomAugspurger is this doable with the latest mpl release?

[TomAugspurger]

I'm not sure. I don't think it's a blocker for 0.24.0 though.

[TomAugspurger]

Pushing to 0.25

[jorisvandenbossche]

Leaving for after 0.25? (1.0)

[TomAugspurger]

Perhaps. We had at least one release where the warning was broken.

…

On Jun 30, 2019, at 14:17, Joris Van den Bossche ***@***.***> wrote: Leaving for after 0.25? (1.0) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[jorisvandenbossche]

Anyway, given that is a quite annoying change (if you are relying on it), I don't think it hurts to wait a bit longer.

[TomAugspurger]

Can we do this for 1.0? Right now matplotlib is ~25% of our import time(?), and this is the only thing requiring a non-lazy import.

[jorisvandenbossche]

Yes, I think we should try do it for 1.0. We have been raising the deprecation warning for some time now.

[TomAugspurger]

OK. I'll try to get to it today.

…

On Thu, Sep 19, 2019 at 11:52 PM Joris Van den Bossche < ***@***.***> wrote: Yes, I think we should try do it for 1.0. We have been raising the deprecation warning for some time now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18720?email_source=notifications&email_token=AAKAOIXP6ALKWBZ2ZKC5HDDQKRJI3A5CNFSM4EHS4YAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7FRYFI#issuecomment-533404693>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIT3D7TY7DDVBNJOMNTQKRJI3ANCNFSM4EHS4YAA> .