Implement missing tests, fix offset floordiv, rfloordiv, fix return types #19738
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19738 +/- ##
==========================================
+ Coverage 91.58% 91.61% +0.02%
==========================================
Files 150 150
Lines 48862 48862
==========================================
+ Hits 44750 44763 +13
+ Misses 4112 4099 -13
Continue to review full report at Codecov.
|
| @@ -13,6 +16,135 @@ | |||
|
|
|||
|
|
|||
| class TestTimedeltaArithmetic(object): | |||
There was a problem hiding this comment.
as I said in another PR, pls create a
pandas/tests/scalar/timedelta/test_arithmetic to add these 2
There was a problem hiding this comment.
let's do that first so that its then easier to see the changes in this.
There was a problem hiding this comment.
OK. Will open a new PR that just moves tests without making any actual changes.
There was a problem hiding this comment.
Edit: it will add tests that currently pass, will not remove any existing tests or touch anything outside of the tests.
jreback
added
Testing
|
Closing n favor of #19752 plus followups |
This splits off of #19365 a bunch of peripheral changes that were never intended to be part of #19365 in the first place.
Implements many tests in the "how is there not already a test for that!?" category
Fixes(+tests) Timedelta // DateOffset and DateOffset // Timedelta
Fixes(+tests) return types for
Timedelta.__add__, __radd__, __sub__, __rsub__(np.timedelta64)(ATM returnstimedelta64)Fixes a typo in test_construction that causes a dummy assertion to be made instead of the intended assertion.
closes #xxxx
tests added / passed
passes
git diff upstream/master -u -- "*.py" | flake8 --diffwhatsnew entry