Fix import formatting using isort

[alimcmaster1]

Following on from #23048. We now need to run isort on all *.py files in the codebase that we are ignoring in CI see here. Information on Isort here

Useful commands:

To sort imports in files in pandas directory ( ignoring those explicitly mentioned in setup.cfg)
isort --recursive pandas

To check imports are formatted correctly:
isort --recursive --check-only pandas

Find a directory you wish to fix from the list below( larger directories by # of files)
And comment on here that you are working on fixing. To avoid duplicated efforts.

Directories we need to cover:

• pandas/*.py ( in progress @alimcmaster1 )
• pandas/util/ ( in progress @alimcmaster1 )
• pandas/io/ ( in progress @alimcmaster1 )
• pandas/core/ ( in progress @alimcmaster1 )
• pandas/core/indexes/ ( in progress @alimcmaster1 )
• pandas/core/dtypes/ (@alexander-ponomaroff )
• pandas/core/groupby/ (@alexander-ponomaroff )
• pandas/core/reshape/ (@streeck)
• pandas/core/computation/ (@streeck)
• pandas/tests/indexes/ (@thoo)
• pandas/tests/indexes/multi
• pandas/tests/indexes/interval
• pandas/tests/indexes/timedeltas
• pandas/tests/series/ (@thoo)
• pandas/tests/arrays/ (@thoo)
• pandas/tests/util/ (@thoo )
• pandas/tests/extension/ (@mwoss )
• pandas/tests/io/parser/ (@mwoss )
• pandas/tests/io/formats/
• pandas/tests/io/msgpack/
• pandas/tests/io/*.py
• pandas/tests/scalar/
• pandas/tests/tslibs/
• pandas/tests/groupby/ (@sam-cohan )
• pandas/tests/plotting/ (@pvarshney1729 )
• pandas/tests/frame/ (@pvarshney1729 )
• pandas/tests/indexing/ (@amphy )

PRs must contain no more than 20 files.

For new contributors please first take a look at our Contributing Guide

Pandas-Dev: Could we please add the following labels "Style", "Good first Issue", Contributions Welcome" and any more you feel appropriate.

Thanks,
Alistair

[alexander-ponomaroff]

I would like to help out with this issue. Can I please work on the following directories?

• pandas/core/dtypes/
• pandas/core/groupby/
• pandas/core/reshape/
• pandas/core/computation/

[alimcmaster1]

Hey @alexander-ponomaroff thanks for looking to contribute! I've put you down for dtypes and groupby first so we can concentrate on getting those merged first. Then we can look into the others. Let us know on here if you need any help.

[alexander-ponomaroff]

Thank you very much @alimcmaster1 . I will start working on this as soon as possible.

[thoo]

@alimcmaster1 I will be working on:

pandas/tests/indexes/
pandas/tests/series/
pandas/tests/arrays/
pandas/tests/util/

[alimcmaster1]

thanks both @thoo and @pvarshney1729

[thoo]

@alimcmaster1 Do you want several PR from the same branch ?? I have more than 20 files.

[alimcmaster1]

I would recommend using separate branches so the PRs are independent of each other.

[thoo]

@alimcmaster1 That is what I think. Wait for more PR :) :)

[alexander-ponomaroff]

@alimcmaster1 I've looked into dtypes and groupby, now waiting for CI checks to finish for those two pull requests. Could I now also look into the following directories that I previously requested?

• pandas/core/reshape/
• pandas/core/computation/

[mwoss]

Hi. I would like to help with this issue. May I work on those dirs?

• pandas/tests/extension/
• pandas/tests/io/parser/
• pandas/tests/io/formats/
• pandas/tests/groupby/

[amphy]

I would like to help out with this issue. I will be working on

• pandas/tests/indexing

[alimcmaster1]

Still a few files to be worked on here if anyone is interested. Full list in setup.cfg, post on here if anyone is interested.

[thoo]

@alimcmaster1
Working on

• pandas/tests/frame/
• pandas/tests/indexes/
• pandas/tests/io

[mwoss]

@alimcmaster1
Hi. I will work on:

• pandas/tests/dtypes/
• pandas/tests/arithmetic/
• pandas/tests/plotting/

[simonjayhawkins]

@alimcmaster1 i think there could be an issue isorting asv_bench/benchmarks/, xref #22947

[alimcmaster1]

Thanks @mwoss and @thoo.

I will complete all the leftover files that havn't been mentioned above.

@simonjayhawkins we should just be able to force that import to the end using isort.

[gasparia405]

Are any of the following directories still available?

• pandas/tests/indexes/multi
• pandas/tests/indexes/interval
• pandas/tests/indexes/timedeltas
• pandas/tests/io/formats/
• pandas/tests/io/msgpack/

If so, I would love to take some of them!

[alimcmaster1]

Hey - take a look at the isort section in the setup.cfg - that’s up to date

…

Sent from my iPhone

On 26 Jan 2019, at 14:24, Andrew Gaspari ***@***.***> wrote: Are any of the following directories still available? pandas/tests/indexes/multi pandas/tests/indexes/interval pandas/tests/indexes/timedeltas pandas/tests/io/formats/ pandas/tests/io/msgpack/ If so, I would love to take some of them! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[gasparia405]

@alimcmaster1 Sorry, I missed that in the thread. It looks like the only ones left are the asv_bench/benchmark files, I'll take a crack at some of those. I saw the comment about keeping the setup imports at the bottom of the file, so I'll make sure to keep an eye out for that.

Thank you for responding so quickly before!

[jreback]

@simonjayhawkins actually let's create a new one with the remaining items.