Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: isort tests/groupby #24553

Merged
merged 4 commits into from
Jan 2, 2019
Merged

Conversation

simonjayhawkins
Copy link
Member

xref #23334

@jreback jreback added the Code Style Code style, linting, code_checks label Jan 2, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 2, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

lint error here as well

@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24553 into master will decrease coverage by 49.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24553       +/-   ##
===========================================
- Coverage   92.33%   42.99%   -49.34%     
===========================================
  Files         166      166               
  Lines       52465    52465               
===========================================
- Hits        48443    22559    -25884     
- Misses       4022    29906    +25884
Flag Coverage Δ
#multiple ?
#single 42.99% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.04%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad0cfc...135bb66. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24553 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24553      +/-   ##
==========================================
- Coverage   92.33%   92.33%   -0.01%     
==========================================
  Files         166      166              
  Lines       52465    52465              
==========================================
- Hits        48443    48442       -1     
- Misses       4022     4023       +1
Flag Coverage Δ
#multiple 90.75% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.59% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad0cfc...336b15e. Read the comment docs.

@jreback jreback merged commit 8088fe0 into pandas-dev:master Jan 2, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the isort-groupby branch January 2, 2019 17:57
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants