Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGR: DataFrame.shift(axis=1) raises TypeError when columns is CategoricalIndex #38434

Closed
topper-123 opened this issue Dec 12, 2020 · 1 comment · Fixed by #38504
Closed

REGR: DataFrame.shift(axis=1) raises TypeError when columns is CategoricalIndex #38434

topper-123 opened this issue Dec 12, 2020 · 1 comment · Fixed by #38504
Labels
Bug Categorical Categorical Data Type Regression Functionality that used to work in a prior pandas version
Milestone
1.2

Comments

@topper-123
Copy link
Contributor

A regression since 1.1:

>>> ci = pd.CategoricalIndex(["a", "b"])
>>> df = pd.DataFrame([[1, 2], [3, 4]], index=ci, columns=ci)
>>> df.shift(axis=0)  # ok
     a    b
a  NaN  NaN
b  1.0  2.0
>>> df.shift(axis=1)  # not ok, worked in v1.1
TypeError: 'fill_value=0' is not present in this Categorical's categories
@topper-123 topper-123 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 12, 2020
@topper-123 topper-123 changed the title REGR: DataFrame.shift(Axis=1) when columns are CategoricalIndex REGR: DataFrame.shift(axis=1) raises TypeError when columns is CategoricalIndex Dec 12, 2020
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this issue Dec 13, 2020
@simonjayhawkins
add code sample for pandas-dev#38434
4c576b0
@simonjayhawkins simonjayhawkins added Regression Functionality that used to work in a prior pandas version Categorical Categorical Data Type and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 13, 2020
@simonjayhawkins simonjayhawkins added this to the Contributions Welcome milestone Dec 13, 2020
@simonjayhawkins
Copy link
Member

A regression since 1.1:

first bad commit: [44ce988] BUG: df.diff axis=1 mixed dtypes (#36710) cc @jbrockmendel

simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this issue Dec 13, 2020
@simonjayhawkins
change code sample for pandas-dev#38434
54829b7
@jbrockmendel jbrockmendel mentioned this issue Dec 15, 2020
Merged
5 tasks
@simonjayhawkins simonjayhawkins modified the milestones: Contributions Welcome, 1.2 Dec 15, 2020
@simonjayhawkins simonjayhawkins mentioned this issue May 17, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Categorical Categorical Data Type Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

REG: DataFrame.shift with axis=1 and CategoricalIndex columns jbrockmendel/pandas
2 participants
@simonjayhawkins @topper-123