REG: DataFrame.shift with axis=1 and CategoricalIndex columns #38504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
added
Bug
Algos
|
Thanks for taking this. This PR should IMO be part of 1.2, since it’s a regression since 1.1. |
topper-123
requested changes
Dec 15, 2020
| if periods > 0: | ||
| result = self.iloc[:, :-periods] | ||
| for col in range(min(ncols, abs(periods))): | ||
| # TODO(EA2D): doing this in a loop unnecessary with 2D EAs | ||
| # Define filler inside loop so we get a copy | ||
| filler = self.iloc[:, 0].shift(len(self)) | ||
| result.insert(0, col, filler, allow_duplicates=True) | ||
| result.insert(0, label, filler, allow_duplicates=True) |
There was a problem hiding this comment.
Does this work correctly for periods > 1? Looks like it inserts the same label in all locations, where Id think it should insert self.columns[col]?
There was a problem hiding this comment.
This should be benign because we set result.columns directly below. ill add a test to be on the safe side
| else: | ||
| result = self.iloc[:, -periods:] | ||
| for col in range(min(ncols, abs(periods))): | ||
| # Define filler inside loop so we get a copy | ||
| filler = self.iloc[:, -1].shift(len(self)) | ||
| result.insert( | ||
| len(result.columns), col, filler, allow_duplicates=True | ||
| len(result.columns), label, filler, allow_duplicates=True |
| # GH#38434 | ||
| ci = CategoricalIndex(["a", "b"]) | ||
| df = DataFrame([[1, 2], [3, 4]], index=ci, columns=ci) | ||
| result = df.shift(axis=1) |
There was a problem hiding this comment.
Can you test a 3-column dataframe with periods=2 also?
and whatsnew probably not necessary |
|
added test case with periods=2, removed whatsnew |
jreback
added
the
Regression
5 tasks
|
@meeseeksdev backport 1.2.x |
This comment has been minimized.
This comment has been minimized.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Dec 18, 2020
…tegoricalIndex columns
simonjayhawkins
added a commit
that referenced
this pull request
Dec 18, 2020
…ndex columns (#38555) Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff